JetAttrs - HLT Jet Hypothesis for Jet Moments

The HLT jet hypothesis JetAttrs was added in this development branch. This hypothesis makes cuts on the substructure variables KtDR and jet width for large-R jets, and establishes a framework for the inclusion of more variables and more complicated combinations of variable requirements. This work was done as a Qualification Task with the Jet Signature group. See the Glance page here and internal document regarding the added structures and avenues for future work here.

@martyniu @khoo @ckaldero @kwhalen

This merge request affects 3 packages:

• Trigger/TrigAlgorithms/TrigHLTJetRec
• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TriggerCommon/TriggerMenu

added 21.3 JetEtmiss Trigger TriggerMenu review-pending-level-1 labels

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20670-2019-01-26-16-59
Athena: number of compilation errors 0, warnings 166
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32817]

Hi @asteinhe, some tests are failing. Could you please have a look?

Tadej (L1)

added review-user-action-required label and removed review-pending-level-1 label

I had a quick look. There seem to be two issues:

1. The q-tests fail because there were ESD diffs. I think this happens because Amanda's branch has extra triggers added to the menu. We could just disable those, but it would be useful to keep the examples of how they have been set up. Alternatively, we could treat these as a new reference. @ckaldero, @rbielski, do you have any input on this?
2. The unit test failure is trivial -- it just has to do with an unused variable defined in the python that got caught by the syntax checker. I think just this one:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.3/Trigger/TriggerCommon/TriggerMenu/python/jet/jetattrs_parser.py:9:1: F401 'sys' imported but unused

added 4 commits

• fe7d1bcc...35fcab49 - 2 commits from branch atlas:21.3
• b669b49c - Merge remote-tracking branch 'upstream/21.3' into 21.3_JetAttrs_dev
• a1bd3b9a - Restore TrigHLTJetRecConfig such that KtDR is not computed in minimalist setup -…

Compare with previous version

Hi @khoo,
regarding your first point - perhaps this should be added to v8 menu rather than v7? @aranzazu, @jmontejo, what is the recommendation for new triggers in 21.3 now?

In any case, we should not prevent adding new triggers to 21.3, but since the q-tests run on v7, adding them to v8 wouldn't change the q-test output (I think).

Cheers,
Rafal

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TriggerCommon/TriggerMenu

added review-pending-level-1 label and removed review-user-action-required label

Hello,

All the developments in 21.3 should happen in the v8 menu. In particular, new triggers should be implemented in MC_pp_v8. We see that there are some chains implemented in MC_pp_v7. Which is the JIRA ticket associated to this MR? Please include the Trigger Menus component.

Thanks. Cheers, Javier, Arantxa

added review-user-action-required label and removed review-pending-level-1 label

OK, Amanda is working on putting this in v8. The ticket is ATR-17258.

Hi,

list_unprescaled* should not have been added to the commit. Those were removed from the source tree some time ago and are produced during the build.

Cheers Javier

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TriggerCommon/TriggerMenu

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20670-2019-01-29-03-02
Athena: number of compilation errors 0, warnings 166
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32896]

added review-user-action-required label and removed review-pending-level-1 label