Solution to Missing move assignment operator! (CID# 113566)

Changes made in TrackSegment.cxx/.h and Segment.cxx/.h.

This merge request affects 1 package:

• Tracking/TrkEvent/TrkSegment

added Tracking master review-pending-level-1 labels

@goetz for facilitation.

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20681-2019-01-27-16-54
Athena: number of compilation errors 0, warnings 27
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32831]

added review-user-action-required label and removed review-pending-level-1 label

marked as a Work In Progress

Hi Jyoti, You should also add move semantics to TrackSegment i.e. You should implement

 Trk::TrackSegment::TrackSegment(Trk::TrackSegment&& tseg)
 Trk::TrackSegment& Trk::TrackSegment::operator=(Trk::TrackSegment&& tseg)

similar to what You did for Trk::Segment. Thanks ! Götz

added 1 commit

• 55e34554 - After implementation of suggestions.

Compare with previous version

Hi @goetz,

All your suggestions are now implemented in the new commit: jbiswal/athena@55e34554 . Is this OK?

Regarding the white spaces, they appear to be different in 'vim' text editor. Anyway, I have tried to get rid of them as much as I could.

Jyoti

Sorry, I made a mistake here (I thought I corrected it). You must not delete m_containedMeasBases here. Only before 109 You must delete it.

Implemented in the new commit: 9cd1077e

Is it OK now?

added 1 commit

• 9cd1077e - m_containedMeasBases deletion corrected!

Compare with previous version

I think that looks good ! Thanks !

unmarked as a Work In Progress