Enable creation of muon raw data cache containers in MuonConfig package.

The various bytestream decoding Cfg functions in MuonConfig were assuming the prescence of the new muon cache containers for MDTs and CSCs. This caused errors in the trigger tests (e.g. http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/GITWebArea/nightlies/master/2019-01-27T2257/Athena/x86_64-slc6-gcc62-opt/Athena/UT/TrigUpgradeTest.log.html) because the tools assumed the cache containers exist, but the algorithm to create them was never scheduled. This is now fixed by scheduling that algorithm insiide the Cfg functions for the MDT and CSC decoding. This also means it is no longer needed to schedule the cache creation algorithm by hand in the testing functions (and the corresponding reference files are updated).

mentioned in merge request !20698 (closed)

added 1 commit

• cd94622c - Remove event-by-event info message from MuonCacheCreator

Compare with previous version

unmarked as a Work In Progress

changed the description

Jenkins please retry a build

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonByteStream
• MuonSpectrometer/MuonConfig

Adding @rosati ,@wleight as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20706-2019-01-29-04-57
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32910]

mentioned in merge request !20709 (merged)

Hi @markowen, @tbold, some muon trigger tests are still failing, is this expected?

Thanks @tadej , I confirm your observation. Config problem of the self-tests.

Ok, adding review-user-action-required for now.

added review-user-action-required label and removed review-pending-level-1 label

For one test an input file seems to have moved:

Py:Athena            INFO Obtaining metadata of auto-configuration by peeking into /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/Tier0ChainTests/q221/21.3/myESD.pool.root
ERROR: Failed input file /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/Tier0ChainTests/q221/21.3/myESD.pool.root not accessible

indeed, looking on cvmfs, it now seems to be at: /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/Tier0ChainTests/q221/21.3/v1/myESD.pool.root. I'll switch that.

The other failures are due to mismatches in reference log files, however it looks like the test somehow picks an old reference file (I checked the test works in my local checkout). @iconnell saw a similar thing on !20174 (merged), which seemed to get fixed by a rebuild. Let's see if the same happens here.

added 1 commit

• 6c659734 - Fix ESD input file location for tests

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonByteStream
• MuonSpectrometer/MuonConfig

Adding @rosati ,@wleight as watchers

added review-pending-level-1 label and removed review-user-action-required label

For future it would be good to sync with this. https://gitlab.cern.ch/atlas/athena/blob/master/Control/AthenaConfiguration/python/TestDefaults.py

BTW, Mark, this CI will not run TUT tests. I asusme you have run them locally and indeed the issue is fixed.

@tbold - I just ran all the TUT. Everything looks good apart from TrigUpgradeTest_egammaRunData_ctest. This fails, but only with a difference in the log files:

Py:Athena            INFO leaving with code 0: "successful run"
--- egammaRunData.log-todiff	2019-01-29 09:55:12.970159227 +0000
+++ egammaRunData.ref-todiff	2019-01-29 09:55:12.989158821 +0000
@@ -122,8 +122,8 @@
 TrigSignatureMoniMT                                INFO HLT_2e3_etcut decisions                           16        83        
 TrigSignatureMoniMT                                INFO HLT_e3_etcut                  20        9         8         8         8         
 TrigSignatureMoniMT                                INFO HLT_e3_etcut decisions                            22        107       
-TrigSignatureMoniMT                                INFO HLT_e3e5_etcut                20        20        18        18        18        
-TrigSignatureMoniMT                                INFO HLT_e3e5_etcut decisions                          54        266       
+TrigSignatureMoniMT                                INFO HLT_e3e5_etcut                20        20        18        11        11        
+TrigSignatureMoniMT                                INFO HLT_e3e5_etcut decisions                          54        239       
 TrigSignatureMoniMT                                INFO HLT_e5_etcut                  20        20        17        17        17        
 TrigSignatureMoniMT                                INFO HLT_e5_etcut decisions                            52        255       
 TrigSignatureMoniMT                                INFO HLT_e7_etcut                  20        20        11        11        11        
 post.sh> ERROR: egammaRunData.log and ../share/egammaRunData.ref differ 

so probably I just leave that one for you / egamma guys to sort out?

Thanks Mark, This is addressed in: !20709 (merged)