Removed reference to the EventInfo from the EventIncident and dropped the CheckIOV incident

As part of the migration away from the old-style event info, the reference to EventInfo has been removed from the EventIncident. The clients of EventIncident have been updated such that they now pass event information via EventContext, which is a data member of the Gaudi Incident class.

Several standalone algorithms (either test or conditions loading jobs) have been switched to direct usage of event contexts (via getContext()) instead of taking them from the incidents.

Also dropped the redundant CheckIOV incident.

This merge request affects 17 packages:

• AtlasTest/DatabaseTest/IOVDbTestAlg
• Control/AthenaServices
• Control/IOVSvc
• Control/PileUpComps
• Control/RngComps
• Event/EventInfo
• Event/EventInfoMgt
• HLT/Trigger/TrigControl/TrigServices
• InnerDetector/InDetRecTools/PixelToTPIDTool
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/CalibNtupleAnalysisAlg
• PhysicsAnalysis/EventTag/EventTagUtils
• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigSteer/TrigSteering
• Trigger/TrigT1/TrigT1CaloByteStream
• Trigger/TrigT1/TrigT1CaloSim
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TriggerSimulation/TrigSimTransforms

Adding @jchapman ,@rosati ,@wleight ,@fwinkl ,@damazio ,@vpascuzz ,@wiedenma ,@ssnyder ,@rbianchi ,@rbielski as watchers

added Analysis Core Digitization EDM InnerDetector MuonSpectrometer Test Trigger master review-pending-level-1 labels

Explicitly tagging: @ssnyder , @leggett , @akraszna , @jchapman , @mnowak , @fwinkl and @gemmeren

I'm marking this MR as WIP for now.

marked as a Work In Progress

changed the description

removed review-pending-level-1 label

approved this merge request

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20723-2019-01-29-09-53
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32927]

approved this merge request

All in all I of course like the changes.

I was just wondering: Since in some files you removed all EventInfo includes, did you check if the packages/libraries holding those source files still need to link against the EventInfo library after these updates? I would hope to reduce the compile-time dependencies a bit as well.

Cheers, Attila

I completely missed your changes for TrigCOOLUpdateHelper when I first looked at this MR. The hltCoolUpdate methods are actually still needed as we still need to inform the IOVDbSvc to drop the folder content from its cache. Since I am anyway working on this code right now, if you don't mind could you just remove those changes from your MR?

added 1 commit

• aa0eb6f0 - Removed reference to the EventInfo from the EventIncident and dropped the CheckIOV incident

Compare with previous version

resolved all discussions

Hi @akraszna , thanks for reviewing this MR. I implement the replacements of "BeginRun" with IncidentType::BeginRun. As for removing the dependencies on the EventInfo package, I don't think we can do much. For those files where I removed all EventInfo includes, there are other files in the same package which still need it.

We should be able to do a better job in cleaning up the redundant dependencies, once we completely migrate away from the old-style EventInfo.

unmarked as a Work In Progress

changed the description

This merge request affects 17 packages:

• AtlasTest/DatabaseTest/IOVDbTestAlg
• Control/AthenaServices
• Control/IOVSvc
• Control/PileUpComps
• Control/RngComps
• Event/EventInfo
• Event/EventInfoMgt
• HLT/Trigger/TrigControl/TrigServices
• InnerDetector/InDetRecTools/PixelToTPIDTool
• MuonSpectrometer/MuonCalib/MuonCalibStandAlone/CalibNtupleAnalysisAlg
• PhysicsAnalysis/EventTag/EventTagUtils
• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigSteer/TrigSteering
• Trigger/TrigT1/TrigT1CaloByteStream
• Trigger/TrigT1/TrigT1CaloSim
• Trigger/TrigT1/TrigT1CaloTools
• Trigger/TriggerSimulation/TrigSimTransforms

Adding @jchapman ,@rosati ,@wleight ,@fwinkl ,@damazio ,@vpascuzz ,@wiedenma ,@ssnyder ,@rbianchi ,@rbielski as watchers