Change defining Parameter interface for NeutralParticle to be the same as…

Change defining Parameter interface for NeutralParticle to be the same as TrackParticle, cleaner and MT compatible. i.e the static and returning by reference are now automatic and by value (like the trackParticle).

There is a case clients depend on this "feature" , hopefully this will not be the case i.e the CI will tell us

This merge request affects 1 package:

• Event/xAOD/xAODTracking

Adding @rbianchi as watcher

added EDM master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20731-2019-01-29-21-50
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32956]

Hey @christos

Changes and CI look fine from my point of view but I don't understand the last comment in the MR description. Will there be a problem with the change or won't it? Could you please clarify?

Kira (L1)

added review-user-action-required label and removed review-pending-level-1 label

changed the description

It appears no , things compile and tests run, but did not know if this would be the case 100% , i.e wanted to see the CI for this

added review-pending-expert label and removed review-user-action-required label

added review-pending-level-1 label and removed review-pending-expert label

Ok then it's fine and can be approved.

Kira (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit a9f60e61

added sweep:ignore label