Changes in the TileCalibAlgs package

Retrieving or recording objects into StorGate have been changed from raw to using DataHandles Large multidimensional arrays are created on the heap now instead to avoid issues.

This merge request affects 1 package:

• TileCalorimeter/TileCalib/TileCalibAlgs

Adding @pavol ,@solodkov ,@harkusha as watchers

added JetEtmiss Tile master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20732-2019-01-29-21-33
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 32960]

CHanges and CI look fine from my point of view but regarding the large number of changes it might be that I missed something. In addition, there is a lot memory management introduced, so passing on to L2.

Kira (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Hi @tmkrtchy ,

looks to me fine as well, I understand the need to have this changed. But please, when you will touch this code next time, replace all hardcoded numbers in arrays dimensions by some const variables, or symbolic names, to improve readability of the code.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

added review-user-action-required label and removed review-approved label

added 1 commit

• fa236085 - Defined numbers for arrays

Compare with previous version

This merge request affects 1 package:

• TileCalorimeter/TileCalib/TileCalibAlgs

Adding @pavol ,@solodkov ,@harkusha as watchers

added review-pending-level-1 label and removed review-user-action-required label

These changes look good to me, but changing label to user action required until the discussions are resolved.

Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20732-2019-02-01-15-51
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33141]

added 686 commits

• fa236085...a4660b80 - 685 commits from branch atlas:master
• 5cc21ccf - Merge remote branch 'upstream/master'

Compare with previous version

This merge request affects 1 package:

• TileCalorimeter/TileCalib/TileCalibAlgs

Adding @pavol ,@solodkov ,@harkusha as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20732-2019-02-08-02-40
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 33517]

Hi @tmkrtchy,

Please can you confirm that all issues have been addressed by closing the discussions? Then I am happy to approve this MR.

Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

resolved all discussions

Hi @cnellist, Yes, the issues have been addressed. Thank you. Tigran

mentioned in merge request !20981 (closed)

Hi @tmkrtchy.

Thanks. I will approve it now.

Clara (L1, overtime)

added review-approved label and removed review-user-action-required label

resolved all discussions

merged

mentioned in commit 4946b6e7

added sweep:ignore label

added changes-digitization-output label