Add methods using EventContext in some SCT conditions tools (ATLASRECTS-4831).

Add methods using EventContext in

• SCT_MajorityConditionsTool
• SCT_FlaggedConditionTool
• SCT_MonitorConditionsTool
• SCT_ReadCalibChipDataTool
• SCT_ReadCalibDataTool
• SCT_SensorsTool

https://its.cern.ch/jira/browse/ATLASRECTS-4831

RunTier0Tests.py was fine. RunTier0Tests.log

This merge request affects 2 packages:

• InnerDetector/InDetConditions/SCT_ConditionsAlgorithms
• InnerDetector/InDetConditions/SCT_ConditionsTools

Adding @oda as watcher

added InnerDetector master review-pending-level-1 labels

changed the description

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20783-2019-01-31-10-45
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33069]

Looks OK. I suppose at some point the old "helper" methods will be removed?

Tadej (L1)

added review-approved label and removed review-pending-level-1 label

Hi @tadej

Which helper methods?

The methods that read the event context and pass it to the new ones. I ask more of curiosity.

If we use const EventContext* p_ctx instead of const EventContext& ctx, we can set its default value as nullptr and only one method is needed. But AthReentrantAlg::execute has const EventContext& ctx as its argument. I think the use of const EventContext* p_ctx brings confusion.

Later on, if the use case of EventContext becomes more clear, I will update the codes.

merged

mentioned in commit 2accb4b7

added sweep:ignore label