Move DataQualityTools to ReadHandles

changed title from Move DataQualityTools to ToolHandles to Move DataQualityTools to ReadHandles

This merge request affects 3 packages:

• Control/AthenaMonitoring
• DataQuality/DataQualityTools
• DataQuality/DataQualityUtils

Adding @ssnyder ,@rbianchi as watchers

added Core DQ master review-pending-level-1 labels

Jenkins please retry a build

This merge request affects 3 packages:

• Control/AthenaMonitoring
• DataQuality/DataQualityTools
• DataQuality/DataQualityUtils

Adding @ssnyder ,@rbianchi as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20792-2019-01-31-18-48
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33084]

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20792-2019-01-31-19-36
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33088]

added 1 commit

• fa45a7d4 - Fix build of CaloMonitoring (add dependency)

Compare with previous version

This merge request affects 4 packages:

• Calorimeter/CaloMonitoring
• Control/AthenaMonitoring
• DataQuality/DataQualityTools
• DataQuality/DataQualityUtils

Adding @pavol ,@ssnyder ,@rbianchi as watchers

added Calorimeter JetEtmiss labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20792-2019-02-01-02-29
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33104]

Hi @ponyisi, it seems that some job options still need to be updated as the q-tests are failing. Could you have a look?

Tadej (L2)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 869eb9fa - Do not set a removed property

Compare with previous version

This merge request affects 4 packages:

• Calorimeter/CaloMonitoring
• Control/AthenaMonitoring
• DataQuality/DataQualityTools
• DataQuality/DataQualityUtils

Adding @pavol ,@ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20792-2019-02-01-15-55
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33131]

Hi @ponyisi ,

The q-tests are still failing.

Cheers, Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 076aeb16 - Bugfix in AthenaMonManager, DQTLumiMonTool; cleanups

Compare with previous version

This merge request affects 4 packages:

• Calorimeter/CaloMonitoring
• Control/AthenaMonitoring
• DataQuality/DataQualityTools
• DataQuality/DataQualityUtils

Adding @pavol ,@ssnyder ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20792-2019-02-02-18-56
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33201]

added Squash commits label

Hi Tadej - this is a strict port of deprecated code. I will add the "override"s but other structural changes (e.g. using EventContext) are out of scope.

OK. The rest looks fine. If the code is deprecated, you could just skip adding overrides to avoid extra work.

OK, it would certainly be easier to avoid the overrides...

Let's approve it then. Note that in the future, try to update copyright headers to the current year. Also sorting the header includes helps with the readability.

Tadej (L1)

added review-approved label and removed review-pending-level-1 label

resolved all discussions

merged

mentioned in commit 5a6af9ef

added sweep:ignore label