Add LAr with HGTD Xml Dictionary, needed for ATLAS-P2-ITK-17-05-00 geometry
Merge request reports
Activity
added Geometry review-pending-level-1 labels
CI Result SUCCESSAthena externals cmake make required tests optional tests Full details available at NICOS MR-20833-2019-02-01-22-35
Athena: number of compilation errors 0, warnings 166
CI Jenkins server is switched to https://atlas-sit-ci.cern.ch. It is accessible world-wide (behind CERN SSO). In old links to Jenkins server aibuild080.cern.ch:8080 should be replaced with atlas-sit-ci.cern.ch For experts only: Jenkins output [CI-MERGE-REQUEST 33170]Hi @nstyles,
this is indeed needed since it is required by the geo tag, even though it is not needed if we run with the HGTD option switched off (as we should).
One comment I have related to the HGTD simulation, which is anyhow not relevant for this MR, is that the most recent developments are happening in 20.20.X(.Y)-VAL and are not ported yet in 21.9. I think we should coordinate the effort with the HGTD group to make a proper implementation of the relevant code.
Cheers, Noemi
added review-approved label and removed review-pending-level-1 label
One comment I have related to the HGTD simulation, which is anyhow not relevant for this MR, is that the most recent developments are happening in 20.20.X(.Y)-VAL and are not ported yet in 21.9. I think we should coordinate the effort with the HGTD group to make a proper implementation of the relevant code.
Agreed. The goal should be to bring the latest developments in 20.20.X.Y-VAL which support HGTD into 21.9, and update them as necessary for compatibility, planned future implementation differences, etc. This should be done in collaboration with the HGTD group.
mentioned in commit 09627014