TrigInDetAnalysisUser: Fix gcc8 compilation warning.

Compilation warning: unneeded parentheses.

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigInDetAnalysisUser

Adding @sutt as watcher

added Trigger master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-20930-2019-02-06-09-35
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 33394]

Changes and CI look fine. Approving.

Kira (L1)

added review-approved label and removed review-pending-level-1 label

Hi, actually can we not include this change. We are currently trying to synchronise the code between 21.3 and master, so until we have finished this, would prefer not to add any code that might lead to conflicts and prevent automatic sweeping from 21.3 to master.

Cheers Mark

merged

mentioned in commit cb0dab2a

Thanks Walter, perhaps you did not understand my request ...

Hi, actually can we _not_ include this change. We are currently trying to synchronise the code between 21.3 and master, so until we have finished this, would prefer not to add any code that might lead to conflicts and prevent automatic sweeping from 21.3 to master.

It would be a good idea to test your code compiles cleanly with gcc8 before requesting a merge.

Sorry, I wasn't aware that master was using a newer version compiler. I wonder about the compatibility of trigger code between 21.3 and master if using a newer compiler, particularly if people start using c++ extensions that are not in the default 6.2 used for 21.3.

Cheers Mark

The gcc8 build of master uses c++17; the gcc6.2 builds of master are meant to be abandoned soon.

Will this gcc change also be applied to 21.3 ?

Cheers Mark

added sweep:ignore label

mentioned in commit 971f11ac

mentioned in merge request !21063 (merged)

mentioned in commit 9c64e5df

mentioned in commit c1da7acd

mentioned in merge request !21124 (merged)

mentioned in commit 417086d7