Sweeping !21063 from 21.3 to 21.9. Sweeping !20930 from master to 21.3

Sweeping !20930 (merged) from master to 21.3

See merge request !21063 (merged)

Adding original author @rbielski as watcher.

restored source branch cherry-pick-9c64e5dfda-21.9

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigInDetAnalysisUser

Adding @sutt as watcher

added 21.9 Trigger review-pending-level-1 labels

CI Result FAILURE

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21124-2019-02-14-07-35
Athena: number of compilation errors 1, warnings 167
For experts only: Jenkins output [CI-MERGE-REQUEST 33806]

Hi, this change is only for a file that builds a standalone (athena free) executable that we use to create our plots from histogram files, and is not part of the athena code directly.

None of the required or optional tests actually run this code, and since this package compiles ok, then this can be accepted - there is no reason to wait for completely unrelated packages that are not affected by this package, and which this package does not use to build ok.

Cheers Mark

Hi @sutt,
this file does get compiled in the Athena project. This is why we saw the gcc8 warning which this MR is fixing. But I agree with everything else you said, there's no reason not to merge this trivial change straight away.

Cheers,
Rafal

Hi Rafal,

yes it compiles as part of the athena project to create some standalone executables that go into the install area, but what I meant was that the code itself is never linked with the athena executable, and does not use any athena code over and above the code in the TrigInDetAnalysis packages, so no other athena packages have any impact on this code, and no other packages in athena (not even the other TrigInDetAnalysis packages) depend on the actual code in TrigInDetAnalysisUser.

The TrigInDetValidation package does use the standalone executables for the post-processing of the validation in ART, but again, these only run after the athena stages of the ART jobs have completed, so none of the tests over and above whether this package compiles have any impact on, or are affected by this code.

Cheers Mark

added review-approved label and removed review-pending-level-1 label

Approving, as this is a trivial change and unrelated to the error.

Eric (L1)

Many thanks Eric.

Cheers Mark

merged

mentioned in commit 417086d7

mentioned in merge request !20913 (merged)