xAOD Jet : Atlas static thread safety checker

The bulk of this is more of a tedious exercise on const correctness which pretty much resulted on adding const in a few places ... The core of the xAOD::Jet i.e the Jet_v1 etc should be fully const -correct and MT safe.

There are 2 places/pieces of code I marked as non thread safe using ATLAS_NOT_THREAD_SAFE

• One is the test --> I do not expect we want to fix it for now, as is a test ....
• The other is a few methods in the JetContainerInfo.cxx , this we need to prb a fix at some stage.

Mentioning @khoo and @delsart for their info.

Christos

changed the description

This merge request affects 1 package:

• Event/xAOD/xAODJet

Adding @rbianchi as watcher

added EDM JetEtmiss master review-pending-level-1 labels

changed the description

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21178-2019-02-15-23-49
Athena: number of compilation errors 2, warnings 7
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST 33930]

added 1 commit

• 511acdb5 - fix compilation of clients

Compare with previous version

This merge request affects 3 packages:

• Event/xAOD/xAODJet
• Reconstruction/Jet/JetUtils
• Trigger/TrigAlgorithms/TrigEFMissingET

Adding @rewang ,@mronzani ,@rbianchi ,@ggallard as watchers

added Reconstruction Trigger labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21178-2019-02-16-05-27
Athena: number of compilation errors 1, warnings 3
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST 33941]

Hi @christos , apparently one client was forgotten.....

  Pavol [as L2 MR shifter]

yes, 2 more const needed ;) will do it later today ...

added 1 commit

• 6165f4e9 - fix another client than needed const

Compare with previous version

This merge request affects 4 packages:

• Event/xAOD/xAODJet
• Reconstruction/Jet/JetMomentTools
• Reconstruction/Jet/JetUtils
• Trigger/TrigAlgorithms/TrigEFMissingET

Adding @rewang ,@mronzani ,@rbianchi ,@ggallard as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21178-2019-02-16-20-44
Athena: number of compilation errors 0, warnings 3
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST 33962]

Otherwise looks clear to me, approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 30b865ef

added sweep:ignore label