Add magnet auto-configuration for HLT

Add back the code that is responsible for the magnet auto-configuration based on the currents in the configuration ptree when running online or in athenaHLT.py. Add a "Modifier" to enable the auto-configuration by default in testHLT_MT.py.

In addition, make sure the file input peeking is only done in athena.py and not athenaHLT.py.

This merge request affects 3 packages:

• HLT/Trigger/TrigControl/TrigServices
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerRelease

Adding @wiedenma ,@rbielski ,@fwinkl as watchers

added Trigger master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21448-2019-02-26-17-06
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 34446]

@tamartin our decodeBS unit test fails with

Error in <TBufferFile::ReadClass>: The on-file class is "'xAOD::TrigCompositeAuxContainer_v2" which is not compatible with the requested class: "xAOD::TrigCompositeAuxContainer_v1"
Error in <TBufferFile::ReadObject>: got object of wrong class! requested xAOD::TrigCompositeAuxContainer_v1 but got xAOD::TrigCompositeAuxContainer_v2

Is this a known issue?

Looking into this now

Hadn't seen this one up to now, don't think this was the underlying cause of the red mark. But think I see the issue. Taking it to mattermost before opening a JIRA

The changes look ok.

There is failed test TrigUpgradeTest_decodeBS_ctest. @tamartin , did you come to any conclusion what to do with this MR? Should I restart the CI?

L1 shifter

After some more debug - the test should be fixed by !21171 (merged) so suggest re-starting CI here once that is merged

Jenkins please retry a build

This merge request affects 3 packages:

• HLT/Trigger/TrigControl/TrigServices
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerRelease

Adding @wiedenma ,@rbielski ,@fwinkl as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21448-2019-02-28-16-03
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 34594]

Jenkins please retry a build

This merge request affects 3 packages:

• HLT/Trigger/TrigControl/TrigServices
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerRelease

Adding @wiedenma ,@rbielski ,@fwinkl as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake	N/A	N/A
make	N/A	N/A
required tests	N/A	N/A
optional tests	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on NICOS Web UI
For experts only: Jenkins output [CI-MERGE-REQUEST 34668]

No longer waiting on !21171 (merged), but now waiting on !21563 (merged) :(

Hi @tamartin.

Ah, ok. Thanks. I thought it had been resolved.

Clara (L1)

Bit of a whack-a-mole situation this week with MRs inadvertently affecting the trigger upgrade tests

Jenkins please retry a build

This merge request affects 3 packages:

• HLT/Trigger/TrigControl/TrigServices
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerRelease

Adding @wiedenma ,@rbielski ,@fwinkl as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21448-2019-03-02-00-18
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 34695]

Approving.

Cheers, Johannes (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit f074cc59

added sweep:ignore label