IDC_Overlay cleanup

This MR is unfortunately quite large. I will try to summarise what was done:

1. IDC_OverlayBase package was reorganised a little bit

   • IDC_OverlayCommon contains only static methods from the Overlay namespace
   • IDC_OverlayBase class has only member functions. Due to some issues, it is still basing on OverlayAlgBase.

2. PixelOverlay, SCTOverlay and TRTOverlay have been updated for the changes.

3. MDTOverlay has been updated and cleaned up to be closer in the naming to other overlay algorithms.

Note that the TRT overlay algorithm will be additionally cleaned-up in a follow-up MR so I plan to fix all typos and inconsistent naming later.

The output does not change in the test case although Pixel unit tests had to be changed.

/cc @jchapman

added 1 commit

• b6fdf91a - TMP CSC

Compare with previous version

added Overlay master labels

added 259 commits

• b6fdf91a...37336bf3 - 256 commits from branch atlas:master
• 85b80294 - Cleanup IDC_OverlayBase
• 93fa901c - Cleanup InDetOverlay
• a7187de6 - Cleanup MdtOverlay

Compare with previous version

added 4 commits

• afd92c63 - Migrate InDetOverlay to Overlay::debugPrint
• fccf638e - Cleanup IDC_OverlayBase
• 10a9310a - Cleanup InDetOverlay
• 9ead66fe - Cleanup MdtOverlay

Compare with previous version

added 7 commits

• 103a26f5 - Cleanup IDC_OverlayBase package
• e395706f - Update PixelOverlay for IDC_OverlayBase changes
• ff832053 - IDC
• ecdea36a - More pixel
• 74266f51 - Update SCTOverlay for IDC_OverlayBase changes
• 6c8a64c9 - Update TRTOverlay for IDC_OverlayBase changes
• 1ffaccd4 - Cleanup MdtOverlay and remove MuonOverlayBase class

Compare with previous version

added 25 commits

• 1ffaccd4...60d4bfad - 19 commits from branch atlas:master
• f41adee6 - Migrate InDetOverlay to Overlay::debugPrint
• 3f8a1bfa - Cleanup IDC_OverlayBase package
• af7befcd - Update PixelOverlay for IDC_OverlayBase changes
• 95abb0a9 - Update SCTOverlay for IDC_OverlayBase changes
• e4f27424 - Update TRTOverlay for IDC_OverlayBase changes
• 3b460ccd - Cleanup MdtOverlay and remove MuonOverlayBase class

Compare with previous version

added 5 commits

• aa340df5 - Cleanup IDC_OverlayBase package
• 670fbd31 - Update PixelOverlay for IDC_OverlayBase changes
• 4afe2e7f - Update SCTOverlay for IDC_OverlayBase changes
• d7b835e6 - Update TRTOverlay for IDC_OverlayBase changes
• a559cc4f - Cleanup MdtOverlay and remove MuonOverlayBase class

Compare with previous version

changed the description

Jenkins please retry a build

This merge request affects 4 packages:

• Event/EventOverlay/IDC_OverlayBase
• InnerDetector/InDetRawAlgs/InDetOverlay
• MuonSpectrometer/MuonOverlay/MdtOverlay
• MuonSpectrometer/MuonOverlay/MuonOverlayBase

Adding @jchapman ,@rosati ,@wleight ,@tkharlam ,@ahaas ,@tadej as watchers

added EDM InnerDetector MuonSpectrometer labels

changed the description

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21454-2019-03-02-23-08
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 34731]

added 6 commits

• 3cb724d0 - Migrate InDetOverlay to Overlay::debugPrint
• 992b5874 - Cleanup IDC_OverlayBase package
• f5fc2246 - Update PixelOverlay for IDC_OverlayBase changes
• 9d3c462f - Update SCTOverlay for IDC_OverlayBase changes
• 6ea11af0 - Update TRTOverlay for IDC_OverlayBase changes
• d2ccb46b - Cleanup MdtOverlay and remove MuonOverlayBase class

Compare with previous version

added 97 commits

• d2ccb46b...7f193229 - 92 commits from branch atlas:master
• 644ab776 - Cleanup IDC_OverlayBase package
• fa95201a - Update PixelOverlay for IDC_OverlayBase changes
• 5d60d9a3 - Update SCTOverlay for IDC_OverlayBase changes
• d576f51f - Update TRTOverlay for IDC_OverlayBase changes
• 4bd0d0cf - Cleanup MdtOverlay and remove MuonOverlayBase class

Compare with previous version

unmarked as a Work In Progress

changed the description

This merge request affects 4 packages:

• Event/EventOverlay/IDC_OverlayBase
• InnerDetector/InDetRawAlgs/InDetOverlay
• MuonSpectrometer/MuonOverlay/MdtOverlay
• MuonSpectrometer/MuonOverlay/MuonOverlayBase

Adding @jchapman ,@rosati ,@wleight ,@tkharlam ,@ahaas ,@tadej as watchers

added review-pending-level-1 label