TrigCaloRec: enable static thread safety checker

Enable the static thread safety checker for TrigCaloRec. Since this package contains both non-thread-safe legacy trigger code as well as the new MT code, a few files needed to be marked as non-thread-safe:

• FullCaloCellContMaker
• RoITileCellContMaker
• RoILArHadCellContMaker
• RoILArEMCellContMaker
• RoIFCalEmCellContMaker
• RoIFCalHadCellContMaker

Those files will sooner or later be deleted along the entire trigger legacy code.

I would like @damazio to explicitly approve that the above files are indeed legacy and will never be used in athenaMT. Also including @ssnyder in case he has any comments on the general use of the thread checker as I would like to proceed in a similar way with all trigger packages.

References:

• https://twiki.cern.ch/twiki/bin/viewauth/AtlasComputing/CheckerGccPlugins#thread_plugin
• https://gitlab.cern.ch/atlas/atlasexternals/tree/master/External/CheckerGccPlugins

This merge request affects 1 package:

• Trigger/TrigAlgorithms/TrigCaloRec

Adding @damazio as watcher

added Trigger master review-pending-level-1 labels

Thanks for the report.. I will look at how to do it! Thanks, Denis

Sorry, what do you mean Denis? What are you going to do?

I thought I needed to mark somehow the files. Now I see I only need to approve. Yes, all this is legacy file. But I think more code is also legacy file, like TrigCaloClusterMaker, TrigCaloCellMaker and TrigCaloTowerMaker.. Cheers, Denis

Thanks Denis. The other code (although legacy) doesn't have any problems flagged by the checker (this doesn't mean it's thread-safe obviously, it just means there are no violations of const-ness, etc.). Can you then just click the "Approve" button at the top of this MR?

approved this merge request

done! First time I do it! Cannot say anymore that there isn't something easy to be done with git!!! ;-)

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21526-2019-02-28-16-01
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 34597]

added review-approved label and removed review-pending-level-1 label

Looks fine as far as it goes.

merged

mentioned in commit 2f762d6a

added sweep:ignore label