Fix LArG4Identifier assignment for hits from step in Back Outer Barrette

Patch to fix the LArG4Identifier values assigned to hits from steps in the Back Outer Barrette in the negative endcap. Should resolve issues seen in ATLASSIM-4020.

unmarked as a Work In Progress

Let's test this one out now - the patch is switched off by default, so the output should be unaffected.

This merge request affects 2 packages:

• LArCalorimeter/LArG4/LArG4Code
• LArCalorimeter/LArG4/LArG4EC

Adding @pavol as watcher

added JetEtmiss LAr Simulation review-pending-level-1 labels

CI Result FAILURE

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21530-2019-03-26-20-53
Athena: number of compilation errors 0, warnings 165
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST 36006]

I guess you need to update the reference? :)

added review-user-action-required label and removed review-pending-level-1 label

added 155 commits

• 4c442b2c...daf77651 - 153 commits from branch atlas:21.0
• ef6c05e7 - Patch to fix the LArG4Identifier values assigned to hits from steps in the...
• e5840b34 - Add useful debugging output to LArG4SimpleSD - switched off by default

Compare with previous version

resolved all discussions

This merge request affects 2 packages:

• LArCalorimeter/LArG4/LArG4Code
• LArCalorimeter/LArG4/LArG4EC

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

removed review-pending-level-1 label

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21530-2019-03-28-20-09
Athena: number of compilation errors 0, warnings 165
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST 36132]

added review-pending-level-1 label

This merge request affects 2 packages:

• LArCalorimeter/LArG4/LArG4Code
• LArCalorimeter/LArG4/LArG4EC

Adding @pavol as watcher

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21530-2019-04-05-14-36
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 36579]

Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

Hi @janders,

Can this one be merged please? It would be useful to have a release with this change too if possible.

Cheers,

John

merged

mentioned in commit 332b9563

added sweep:done label

mentioned in commit 958dbf8c

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/739/console for details)

mentioned in merge request !22549 (merged)

mentioned in commit cc9bb110

mentioned in merge request !22918 (merged)

mentioned in commit 8d7ab8fb