Patch Simulation RunTier0Test job, so that it works in AthSimulation builds

This merge request affects 1 package:

Tools/PROCTools

Adding @amete as watcher

added Tools review-pending-level-1 labels

mentioned in merge request !21647 (merged)

Thanks a lot for the MR. The only real issue I predict here is that should the user provide his/her own postInclude in the external arguments, it's possible that it will be completely ignored. Do we know how the transform behaves when it sees something like:

Sim_tf.py [...] --postInclude 'foo' [...] --postInclude 'bar'

Best, Serhan

Hi @amete,

I checked and in your example the transform would see 'bar', but not 'foo'. The same would be true if we made a new s-tag though.

Cheers,

John

@janders could you merge this one when you have a minute please?

Hi @jchapman,

As I suspected, thanks for checking. I think the best way is to see if there is a postInclude in the extraArgs and if so append 'bar' to 'foo' as --postInclude 'foo' 'bar'. That is a valid way to pass arguments, I think.

Best, Serhan

Hi @amete,

Yes, I just checked and with the syntax that you suggest then the transform sees 'foo' 'bar'. That approach means that you can't suppress any pre/postInclude arguements that the script adds by default to the command though. Not sure that's a big issue, just something to note.

Cheers,

John

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21646-2019-03-05-17-20
Athena: number of compilation errors 0, warnings 165
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST 34840]