Master muonsegmentfinding privatetools gradual

This migrates some muon segment tools to be private.

I also tried to clean up some confusion with the configuration, specifically with MuonSimpleAmbiguityProcessorTool

Some tools must remain private for the moment, such as the TOF Tool in MdtDriftCircleOnTrackCreator, because it turns out that MuGirl is calling setBeta etc on the tool, in execute(). This needs fixing obviously, but is out of the scope of this MR.

I've tested with q431 & q221 and full recompilations of Athena locally, and so this time the result really should be the same!

changed the description

mentioned in merge request !21004 (closed)

Jenkins please retry a build

This merge request affects 17 packages:

• MuonSpectrometer/MuonCnv/MuonPrepRawDataProviderTools
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/CscClusterization
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MdtDriftCircleOnTrackCreator
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonCompetingClustersOnTrackCreator
• MuonSpectrometer/MuonReconstruction/MuonRecExample
• MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MooSegmentCombinationFinder
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerAlgs/CscSegmentMakers
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/DCMathSegmentMaker
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonClusterSegmentMakerTools
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonPatternSegmentMaker
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentOverlapRemovalTools
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentSelectionTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools
• Reconstruction/MuonIdentification/MuidCombinedTools
• Reconstruction/MuonIdentification/MuonCombinedTrackFindingTools

Adding @rosati ,@wleight as watchers

added MuonSpectrometer Reconstruction master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21962-2019-03-16-05-03
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35540]

The 'ToolSvc.MuonClusterSegmentFinderTool.MCTBSLFitter' error looks real. Making this WIP.

marked as a Work In Progress

I'm removing the review-pending labels, while this is marked as WIP.

removed review-pending-level-1 label

added 1 commit

• 043d3f17 - Try to rationalise TrigMuonEf...

Compare with previous version

Jenkins please retry a build

changed the description

unmarked as a Work In Progress

This merge request affects 19 packages:

• MuonSpectrometer/MuonCnv/MuonPrepRawDataProviderTools
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/CscClusterization
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MdtDriftCircleOnTrackCreator
• MuonSpectrometer/MuonReconstruction/MuonRIO_OnTrackCreators/MuonCompetingClustersOnTrackCreator
• MuonSpectrometer/MuonReconstruction/MuonRecExample
• MuonSpectrometer/MuonReconstruction/MuonSegmentCombiners/MuonSegmentCombinerTools/MooSegmentCombinationFinder
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerAlgs/CscSegmentMakers
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/DCMathSegmentMaker
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonClusterSegmentMakerTools
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonLayerSegmentMakerTools
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonPatternSegmentMaker
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentOverlapRemovalTools
• MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentSelectionTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools
• Reconstruction/MuonIdentification/MuidCombinedTools
• Reconstruction/MuonIdentification/MuonCombinedTrackFindingTools
• Trigger/TrigAlgorithms/TrigMuonEF

Adding @rosati ,@wleight as watchers

added Trigger review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-21962-2019-03-20-19-21
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35743]

Hey @emoyse

your tests are still failing. Could you have a look if this is a CI problem (then please feel free to restart the CI) or if this is an error from the code side.

Thanks, Kira(L1)

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build