Propagate the correct track link to sTGC SDO

Save the correct track link in sTGC SDO, to fix a minor bug introduced when cleaning pointers in sTGC_Digitization in MR !21869 (merged).

Bug affecting only 21.3, not the master branch.

This merge request affects 1 package:

• MuonSpectrometer/MuonDigitization/sTGC_Digitization

Adding @jchapman ,@rosati ,@wleight as watchers

added 21.3 Digitization MuonSpectrometer review-pending-level-1 labels

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22050-2019-03-20-18-48
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST 35748]

added review-approved label and removed review-pending-level-1 label

Hi,

looks good!

Cheers, Jannik (L1 shifter)

merged

mentioned in commit f28bd503

added sweep:done label

mentioned in commit 82bfba5a

mentioned in merge request !22096 (merged)

Sweep summary
successful:

• 21.9

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/720/console for details)

mentioned in commit c8d3f19f

added sweep:failed + 1 deleted label

Added ~"alsoTargeting:master" and sweep:failed as I think that these changes need to be manually swept to master.

Is that correct @cchau? If not, please remove the labels and sorry for the noise.

Hi @jchapman, I am not sure it is required for master, probably not. In 21.3, the track link is updated as required by HepMcParticleLink.

            // Update HepMcParticleLink required for making SDO
            const int pileupType = phit.pileupType();
            HepMcParticleLink trklink(hit.particleLink());
            if (m_needsMcEventCollHelper) {
              if(pileupType!=lastPileupType)        {
                currentMcEventCollection = McEventCollectionHelper::getMcEventCollectionHMPLEnumFromPileUpType(pileupType);
                lastPileupType=pileupType;
              }
              trklink.setEventCollection(currentMcEventCollection);
            }

This block of code is not in master (yet?). So hit.particleLink() is used everywhere in master. Cheers, Chav

Hi @cchau,

This syntax should go into master now. Thanks for checking.

Cheers,

John

Hi @cchau,

Have you had a chance to work on this yet?

Cheers,

John

Hi @jchapman, I don't see the syntax above in master yet (at least not for the muon technologies). Should I add it in master just for the sTGC and MM?

Cheers, Chav

Sorry - I really thought that it had been swept. It does seem that it missed getting swept somehow (my fault). I'll make a MR sweeping these changes for all muon technologies and will make this patch at the same time.

removed sweep:done sweep:failed labels

added sweep:done label

mentioned in commit 0882bd63

mentioned in merge request !23454 (closed)

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/781/console for details)