Skip to content
Snippets Groups Projects

Centralised trigger bs output setup in new jo

All threads resolved!

The BS output setup is added to the New JO in this MR. Tagging @rbielski as it may be of interest for him as well

Merge request reports

Pipeline #773953 failed

Pipeline failed for 4a0a20f9 on tbold:centralised-trigger-bs-output-setup-in-new-jo

Approval is optional

Merged by Edward MoyseEdward Moyse 6 years ago (Mar 26, 2019 9:01am UTC)

Merge details

  • Changes merged into master with 4c79ec47.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-22082-2019-03-22-01-47
    :warning: Athena: number of compilation errors 0, warnings 1
    :warning: AthSimulation: number of compilation errors 0, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35818]

  • Tomasz Bold added 1 commit

    added 1 commit

    • a2a15b99 - removed decisions from Aux as they are now part of container data payload

    Compare with previous version

  • This merge request affects 4 packages:

    • Trigger/TrigSteer/TrigOutputHandling
    • Trigger/TrigValidation/TrigUpgradeTest
    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts

    Adding @rbielski as watcher

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-22082-2019-03-22-12-17
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35838]

  • Jannik Geisen resolved all discussions

    resolved all discussions

  • Hi,

    this MR looks good from the L1 side, passing on to L2.

    Best, Jannik (L1)

  • Rafal Bielski mentioned in merge request !22094 (merged)

    mentioned in merge request !22094 (merged)

  • Tomasz Bold added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    Pushed fix. I also missed the point actually.

  • Rafal Bielski resolved all discussions

    resolved all discussions

  • This merge request affects 4 packages:

    • Trigger/TrigSteer/TrigOutputHandling
    • Trigger/TrigValidation/TrigUpgradeTest
    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerJobOpts

    Adding @rbielski as watcher

  • :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :o: :o:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-22082-2019-03-26-00-35
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :warning: AthSimulation: number of compilation errors 0, warnings 2
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 35953]

  • Unrelated CI issues, approving.

    Tadej (L1)

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Edward Moyse mentioned in commit 4c79ec47

    mentioned in commit 4c79ec47

  • Please register or sign in to reply
    Loading