Skip to content
Snippets Groups Projects

Muon digitization ComponentAccumulator configuration

Merged Muon digitization ComponentAccumulator configuration
rtombs/athena:MuonNewConfig into master
All threads resolved!
Merged Rupert Tombs requested to merge rtombs/athena:MuonNewConfig into master
All threads resolved!

New style digitization configuration for the CSC, MDT, TGC and RPC systems, with tests for each.

Link a new HITS file with special configuration for MDT testing.

Add getSpecialConfiguration to DigitizationConfigFlags.py (based on DigitizationReadMetaData.py/doSpecialConfiguration and G4Atlas_Metadata.py/checkForSpecialConfigurationMetadata).

Edited by Rupert Tombs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rupert Tombs added 50 commits

    added 50 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 6 packages:

    • Control/AthenaConfiguration
    • MuonSpectrometer/MuonDigitization/CSC_Digitization
    • MuonSpectrometer/MuonDigitization/MDT_Digitization
    • MuonSpectrometer/MuonDigitization/RPC_Digitization
    • MuonSpectrometer/MuonDigitization/TGC_Digitization
    • Simulation/Digitization

    Adding @jchapman ,@rosati ,@wleight ,@vpascuzz ,@ssnyder ,@rbianchi as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-approved label

    added review-pending-level-1 label and removed review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :o:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-22090-2019-03-28-20-49
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 36152]

  • Ruchi Gupta
    Ruchi Gupta @ruchi ·

    Hi @rtombs Can you resolve the discussion or add WIP if you are still working on this MR? -Ruchi (L1)

  • Rupert Tombs resolved all discussions

    resolved all discussions

  • Rupert Tombs
    Rupert Tombs @rtombs ·
    Author

    Done, thank you @ruchi.

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Should we try a rebuild here, or is it fine to proceed with the review? Clara (L1)

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    I would proceed with the review as this configuration should not affect simulation output.

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Ok thanks, @tadej. The changes look fine to me, and since you commented that you were fine with them too when you were L2, I'm happy to approve. Clara (L1)

  • Clara Nellist added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Walter Lampl merged

    merged

  • Walter Lampl mentioned in commit 2f65d4df

    mentioned in commit 2f65d4df

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply