Metacont sid check on insert

Add check whether sid already exists in MetaCont before trying insert.

https://its.cern.ch/jira/browse/ATLASRECTS-4899

This merge request affects 1 package:

• Control/AthenaKernel

Adding @ssnyder ,@rbianchi as watchers

added Core master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22117-2019-03-23-02-47
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 35891]

It's unclear to me whether the failure is due to this MR. Should we try again?

changed the description

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaKernel

Adding @ssnyder ,@rbianchi as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22117-2019-03-26-00-15
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST 35951]

The same test as before failed, but seems unrelated. The new failure was a timeout on running the test. Please advise. Rel22 validation needs this fix.

I suppose this one does not change simulation output, can you confirm?

Hi Tadej,

I ran the failing test locally without my changes, and I get a similar report of 'leaves differ'. I don't think that error is related to this MR.

Cheers, Jack

ENVIRONMENT

cranshaw@atlaslogin02:sim$ echo $LD_LIBRARY_PATH /cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-03-25T2142/Athena/22.0.1/InstallArea/x86_64-centos7-gcc8-opt/lib:/cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-03-25T2142/AthenaExternals/22.0.1/InstallArea/x86_64-centos7-gcc8-opt/lib:/cvmfs ...

TEST OUTPUT

INFO EVNTtoHITS Patched test successful INFO
INFO All s3126 athena steps completed successfully INFO --------------------------------------------------------------------------------------- INFO Running s3126 Frozen Tier0 Policy Test on HITS for 10 events INFO EOS is not mounted, going to read the reference files from CVMFS INFO Reading the reference file from location /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/Tier0ChainTests/s3126/22.0/v3 ERROR Py:diff-root INFO [EventInfo_p4_McEventInfo]: 180 leaves differ

ERROR Py:diff-root INFO [LArHitContainer_p2_LArHitEMB]: 452259 leaves differ

...

ERROR Py:diff-root INFO [TrackRecordCollection_p2_MuonExitLayer.m_cont.m_time]: 9 leaves differ

ERROR Your tag breaks the frozen tier0 policy in test s3126. See run_s3126/diff-root-s3126.HITS.log file for more information. INFO ----------------------------------------------------- INFO ---------------------- Summary ---------------------- ERROR ALL TESTS: FAILED (-1)

added bugfix urgent labels

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaKernel

Adding @ssnyder ,@rbianchi as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22117-2019-03-29-13-32
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 36203]

Changes look fine to me. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3bfa04c0

added sweep:ignore label