improved Geantino weighting for density averaging in RadiationMapsMaker
sub-step weight is changed from 1 to dl for Geantinos in the density maps. This gives the correct volume averaged density in each bin.
Merge request reports
Activity
added 21.0 Simulation labels
added review-pending-level-1 label
Athena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-22167-2019-03-27-16-15
Hi @menke. I'm looking at this MR now. One comment, it would be good to update the year in the copyright statement when the files are changed if possible. Cheers, Clara (L1)
Hi @cnellist, unfortunately I have not much insight into copyright law. I don't know why there is a range of years in the copyright line and also don't know what the first and last year in the range (and those in between) correspond to. How are files treated that have not been touched for a year or longer in the middle of the range? This file for example was written in 2017 and did not exist before. It borrowed some concepts from FluxRecorder that was written in 2011 and did not exist before.
I was hoping that we could keep this type of edits to a machine with some algorithm (or just a common phrase that fits all). I certainly don't feel competent enough in copyright law to change that line ...Cheers, --Sven
-
Hi @menke. The copyright statements should not be edited, except for the end date when files are updated. So in this case you would change 2017->2019. But it is not hugely important and I am happy to proceed with the review without it. Clara (L1)
added review-approved label and removed review-pending-level-1 label
mentioned in commit 74657565
added sweep:done label
mentioned in commit d7cab4b6
mentioned in merge request !22241 (merged)
Sweep summary
successful:- master
(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/727/console for details)
mentioned in commit 25d4ae60
mentioned in merge request !22918 (merged)
mentioned in commit 8d7ab8fb