TrigUpgradeTest: simplify test definition
Reduce the amount of copy&paste by using a cmake function to define the tests. Some of the test names (and reference file names) have changed as the ctest test name is now derived from the test script name.
Also delete the separate test directory during the cmake configuration to avoid interference with previous runs, i.e. during incremental builds.
cc @rbielski
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbielski as watcher
added Trigger master review-pending-level-1 labels
mentioned in merge request !22216 (closed)
CI Result FAILUREAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-22218-2019-03-28-16-23
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 36128]added 44 commits
-
b9b59777...3642d8d0 - 43 commits from branch
atlas:master
- fcacbc8b - TrigUpgradeTest: simplify test definition
-
b9b59777...3642d8d0 - 43 commits from branch
This merge request affects 1 package:
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbielski as watcher
CI Result FAILUREAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-22218-2019-03-28-21-05
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 36160]added 47 commits
-
fcacbc8b...66edde00 - 47 commits from branch
atlas:master
-
fcacbc8b...66edde00 - 47 commits from branch
This merge request affects 1 package:
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbielski as watcher
CI Result FAILUREAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-22218-2019-03-29-18-00
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 36230]added 1 commit
- 0da9d0a5 - Delete test run directory during configuration
This merge request affects 1 package:
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbielski as watcher
The last pipeline failed with something else for a change...
Traceback (most recent call last): File "EmuNewJOTest.py", line 42, in <module> l1DecoderAcc.mergeAll( TGCCablingConfigCfg( flags ) ) AttributeError: 'ComponentAccumulator' object has no attribute 'mergeAll' Exception RuntimeError: RuntimeError('ComponentAccumulator was not merged!',) in <bound method ComponentAccumulator.__del__ of <AthenaConfiguration.ComponentAccumulator.ComponentAccumulator object at 0x7f636a7ae750>> ignored ERROR in configuration generation stage, stopping ... The following tests FAILED: 1348 - TrigUpgradeTest_emu_newjo_ctest (Failed)
Yes, that's due to !22028 (merged), which got merged 4 hours ago. I fixed it in !22266 (merged).
Edited by Frank Winklmeier CI Result FAILUREAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-22218-2019-03-29-21-41
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 36249]This merge request affects 1 package:
- Trigger/TrigValidation/TrigUpgradeTest
Adding @rbielski as watcher