Skip to content

More clients of CaloNoiseAlg

Walter Lampl requested to merge wlampl/athena:CaloNoiseAlgClients2a into master

This one contains (and superseeds) !22582 (closed).

It contains: Migration of the CaloTopoClusterMaker, CaloClusterMomentsMaker and CaloTopoTowerAlg to the new CaloNoise conditions object, removing the dependency on the thread-unsafe CaloNoiseTool.

On top of this, a number of obsolete features of the TopoClusterMaker are removed. This was discussed on the calo-perf mailing list.

While testing this, I found that the implementation of the CaloNoise::getEffectiveSigma (that is used to account for the double-gaussian noise observed in the TileCal during some periods) was wrong. This MR fixes also this problem. I verified that the resulting CaloCalTopoClusters container remains identical.

It contains also fixes for the CI failures observed in !22582 (closed).

Merge request reports