Skip to content
Snippets Groups Projects

Add new test in TrigAnalysisTest for RDO->RDO_FTK (ATR-19672)

Merged Julie Kirk requested to merge hartj/athena:21.3-addFTKRDOtest2 into 21.3
All threads resolved!

Add new test for RDO->RDO_FTK test_mc_rdo_to_rdoftk_grid Add ls of PHYSVAL_WEB dorectory in test_mc_ntup_physval_grid

Merge request reports

Pipeline #812938 passed

Pipeline passed for fdd710d1 on hartj:21.3-addFTKRDOtest2

Approval is optional

Merged by John Derek ChapmanJohn Derek Chapman 5 years ago (Apr 17, 2019 3:11pm UTC)

Merge details

  • Changes merged into 21.3 with 782983e9.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rafal Bielski
  • Rafal Bielski
  • Julie Kirk added 1 commit

    added 1 commit

    • fdd710d1 - fix test description and art-include

    Compare with previous version

  • Author Developer

    Hi @rbielski , Thanks for the checks. I fixed the first 2. For the post-processing the standard script gives lots of errors due to missing files. I'm thinking that we should maybe split up the script to deal with different output file types. Something we can discuss offline....

    Julie

  • Sounds reasonable, thanks

  • Rafal Bielski resolved all discussions

    resolved all discussions

  • This merge request affects 1 package:

    • Trigger/TrigValidation/TrigAnalysisTest

    Adding @rbielski as watcher

  • :white_check_mark: CI Result SUCCESS

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available at NICOS MR-22721-2019-04-16-20-58
    :warning: Athena: number of compilation errors 0, warnings 141
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 37189]

  • :white_check_mark: CI Result SUCCESS

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available at NICOS MR-22721-2019-04-16-22-18
    :warning: Athena: number of compilation errors 0, warnings 8
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 37204]

  • Hi @hartj and @rbielski,

    from your discussion above I get the impression that you consider changing the MR? Or do you plan to address it in a future MR? If you are fine with the MR as it is, I will approve it, since it looks good and the CI test succeeded.

    Best, Jannik (L1 shifter)

  • Hi @jgeisen,
    Julie has already fixed the two minor issues and we agreed to follow up on the third suggestion in another MR. This one is fine now from our side.

    Cheers,
    Rafal

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 782983e9

  • mentioned in commit 73ff29d8

  • Atlas Nightlybuild mentioned in merge request !22776 (closed)

    mentioned in merge request !22776 (closed)

  • Sweep summary
    successful:

    • 21.0
    • 21.9
    • master

    (see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/750/console for details)

  • mentioned in commit 74a218fc

  • Atlas Nightlybuild mentioned in merge request !22777 (merged)

    mentioned in merge request !22777 (merged)

  • mentioned in commit 17bad7c7

  • Atlas Nightlybuild mentioned in merge request !22778 (merged)

    mentioned in merge request !22778 (merged)

  • mentioned in commit fada29bb

  • mentioned in commit 5ded0528

  • John Derek Chapman mentioned in merge request !22918 (merged)

    mentioned in merge request !22918 (merged)

  • mentioned in commit 8d7ab8fb

  • Please register or sign in to reply
    Loading