Adding l1topo simulation in phase 1 sequence

This MR completes what started here !22414 (merged) . It needs a recent fix to KalmanMETCorrection as implemented here !22766 (merged) and a small function as implemented here !22762 (merged) .

Currently not enabling the L1Topo simulation as default in the simulation sequence. Waiting for MR above to be pushed in 21.3. Among the changes this fixes the jira ticket https://its.cern.ch/jira/browse/ATR-19645 which affected MET and jets energy units conversion (MeV->GeV).

added 21.3 Trigger labels

marked as a Work In Progress

changed the description

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @jchapman ,@vpascuzz as watchers

added review-pending-level-1 label

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22810-2019-04-18-20-48
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 37356]

I approve the MR. Baida L1

added review-approved label and removed review-pending-level-1 label

added 1 commit

• 06bf8632 - adjusting MeV to GeV units

Compare with previous version

added 35 commits

• 06bf8632...63643eb0 - 34 commits from branch atlas:21.3
• 9dfe54e0 - removing old createL1SimulationSequence

Compare with previous version

added 1 commit

• a16b07e8 - updating L1SimulationSequence.py, adding L1topo

Compare with previous version

unmarked as a Work In Progress

marked as a Work In Progress

added 1 commit

• 8e88ba93 - restoring createL1SimulationSequence.py

Compare with previous version

changed the description

Adding @stelzer for info. The option for running the L1topo sim is false by default for now - perhaps I can try to switch that ON, what do you think Joerg? It worked locally but I could test it in a hybrid branch with my changes only https://gitlab.cern.ch/orlando/athena/tree/intermediate-branch .

unmarked as a Work In Progress

changed title from WIP: adding l1topo simulation in phase 1 sequence to Adding l1topo simulation in phase 1 sequence

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @jchapman ,@vpascuzz as watchers

added review-pending-level-1 label and removed review-approved label

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @jchapman ,@vpascuzz as watchers

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22810-2019-04-24-00-41
Athena: number of compilation errors 0, warnings 165
For experts only: Jenkins output [CI-MERGE-REQUEST 37526]

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22810-2019-04-24-01-28
Athena: number of compilation errors 0, warnings 165
For experts only: Jenkins output [CI-MERGE-REQUEST 37527]

Hi @orlando great to see this MR. I think we should get this merged asap, so the L1Topo output can be connected to the CTPEmulation. Cheers, Joerg

Very small minor comments, aside from those I'm happy to approve this ASAP! L1.

added review-user-action-required label and removed review-pending-level-1 label

Hi @tbisanz , the reason for the division by 1000 is mentioned in the description of the MR which also points to a Jira ticket. The reason for it is the the new L1Calo inputs to the L1Topo simulation, notably MET and jets have energy save in MeV instead of GeV; this breaks the L1Topo simulation because the energy values are expected to fall within a certain range.

As for your comment on the twiki I prefer to have it for bookkeeping. We are in a development phase.. Thanks, Nicola

Hi, removing the review-user-action-required label to make sure this is not overlooked due to the turnover of L1 shifter. Thanks Nicola

added review-pending-level-1 label and removed review-user-action-required label

Looks fine to me as well, but please resolve the open discussions.

Eric (L1)

resolved all discussions

done, thanks

Sorry - I think my comment happened at the same time as all the discussions were resolved.

added review-approved label and removed review-pending-level-1 label

Hi @jchapman sorry I had missed your comment, fixing this now

added 1 commit

• 36488735 - Update EnergyInputProviderFEX.cxx MeV to GeV

Compare with previous version

added 1 commit

• 024966f2 - Update JetInputProviderFEX.cxx MeV to GeV

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @jchapman ,@vpascuzz as watchers

added review-pending-level-1 label and removed review-approved label

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoSimulation
• Trigger/TrigT1/TrigT1CaloFexSim

Adding @jchapman ,@vpascuzz as watchers

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22810-2019-04-25-23-17
Athena: number of compilation errors 0, warnings 3
For experts only: Jenkins output [CI-MERGE-REQUEST 37656]

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-22810-2019-04-25-23-32
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST 37655]

resolved all discussions

This looks like it can be approved now.

Tadej (L2)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 0e7ed9b0