Skip to content

Adding photon, jet, b-jets to TMMT

Catrin Bernius requested to merge bernius/athena:signaturesToTMMT into master

Description in short: MR to move jet, photon and b-jet code to TMMT (ATR-19689, ATR-19690, ATR-19688). Tagging @fpastore and @tbold for info.

More details:

  • Renamed the following files:
    • TUT/python/photonMenuDefs.py -> TMMT/python/HLTMenuConfig/Egamma/PhotonSequenceSetup.py
    • TUT/python/jetDefs.py -> TMMT/python/HLTMenuConfig/Jet/JetSequenceDefs.py
    • TUT/python/jetMenuDefs.py -> TMMT/python/HLTMenuConfig/Jet/JetSequenceSetup.py
    • TUT/python/bjetMenuDefs.py -> TMMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py
  • Added photon chain to LS2_v1
  • Comments/questions to jet chains:
    • L1_4J15 seeded chain can’t work as in the definition given in full menu test: HLT_5j70_0eta240_L14J15', l1SeedItem = ['L1_J20'], => need to redefine/make work with multi L1 seed I assume?
  • Comments/questions to Egamma:
    • In TUT/python there is still precisionCaloRec.py =>could this be combined with precisionCaloSequenceSetup.py that is already in TMMT/CommonSequences?
  • Renaming of a few other files (generateChainDefs.py -> GenerateChainDefs.py) to follow file naming convention

Problems encountered and fixed: When adding jet chains to the menu, runMenuTest doesn’t run due to the following ERRORS:

Py:Configurable ERROR attempt to add a duplicate (TopoClusterRecoSequence.HLTCaloCellMaker) ... dupe ignored
Py:Configurable ERROR attempt to add a duplicate (TopoClusterRecoSequence.TrigCaloClusterMakerMT_topo) ... dupe ignored
Py:Configurable ERROR attempt to add a duplicate (AthAlgSeq.MuonCacheCreator) ... dupe ignored
Py:Configurable ERROR attempt to add a duplicate (AthAlgSeq.InDetCacheCreatorTrig) ... dupe ignored
Py:Configurable ERROR attempt to add a duplicate (AthAlgSeq.MuonCacheCreator) ... dupe ignored
Py:Configurable ERROR attempt to add a duplicate (AthAlgSeq.InDetCacheCreatorTrig) ... dupe ignored

Both problems (Calo algo and the CacheCreators) were fixed and are described here: ATR-19703 In addition @tbold also created !22944 (merged) to address the problem with the CacheCreators.

Missing import in ItemDef.py causing the build of the Lvl1 menu to fail, this had been removed in !22888 (merged).

Edited by Catrin Bernius

Merge request reports