RpcDataPreparator: Code cleanup and optimization (ATR-19743)
- Remove unnecessary
InterfaceID
declarations - Move properties to header file
- Remove unnecessary includes
- Calling base class initialize/finalize is not necessary
- Remove event/detector store handles and use them from base class
- Use range-based for loops
- Use
vector::reserve
where possible - Do not import namespaces (
using namespace xyz
) - Optimize eta/phi calculation:
- Use
r^2
to avoid redundantsqr(sqrt(...))
calculation - Use helper to wrap phi
- Use
M_PI
fromcmath
instead ofCLHEP
- Use
Edited by Frank Winklmeier