Add TrigFTKTrackBuilderTool

This MR adds the implementation for the TrigFTKTrackBuilderTool (used in !23656 (merged)), based on the original code by @fscutti.

Some parts of the tool are not yet finalized, like dynamically loading the smearing constants and implementing efficiency corrections. These will be added later in a separate MR, once the file format has been fixed. (This concerns the smearTrack function).

added 11 commits

• aa8ddca2...b7c3bf95 - 10 commits from branch atlas:21.3
• 658f6a38 - Merge remote-tracking branch 'upstream/21.3' into 21.3-TrigFTKTrackBuilderTool

Compare with previous version

unmarked as a Work In Progress

This merge request affects 2 packages:

• Trigger/TrigFTK/TrigFTKFastSimTruth
• Trigger/TrigTools/TrigFTKToolInterfaces

Adding @benhoob ,@jahreda ,@karolos ,@mswiatlo ,@jkuechle as watchers

added 21.3 Trigger review-pending-level-1 labels

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23695-2019-05-27-17-00
Athena: number of compilation errors 0, warnings 163
For experts only: Jenkins output [CI-MERGE-REQUEST 39018]

mentioned in merge request !23767 (merged)

Approving; CI test success. L1 Shifter

changed the description

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

Hi @jkuechle,

Thanks for the tidying that you've done so far. Just a couple more tweaks to make then this code is ready to go in.

Cheers,

John
(21.3 RC)

added 1 commit

• c5348eb7 - Use extends to implement interface and remove empty finalize

Compare with previous version

Hi @bbatool, @jchapman,

thank you for the review! I just implemented the suggested fixes and pushed the changes.

Cheers, Jan

This merge request affects 2 packages:

• Trigger/TrigFTK/TrigFTKFastSimTruth
• Trigger/TrigTools/TrigFTKToolInterfaces

Adding @benhoob ,@jahreda ,@karolos ,@mswiatlo ,@jkuechle as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23695-2019-05-31-19-11
Athena: number of compilation errors 0, warnings 163
For experts only: Jenkins output [CI-MERGE-REQUEST 39272]

resolved all discussions

Looks OK now, approving.

Tadej (L2)

added review-approved label and removed review-pending-level-1 label

Thanks @jkuechle. Looks good to me! Merging now.

John (RC)

mentioned in commit d3789183

merged

added sweep:ignore label

mentioned in commit jkuechle/athena@efcb2a76

mentioned in merge request !24774 (merged)