Skip to content
Snippets Groups Projects

Define and use SiTrackMakerEventData_xk to replace SiTrackMaker_xk::EventData (ATLASRECTS-3037)

Merged Define and use SiTrackMakerEventData_xk to replace SiTrackMaker_xk::EventData (ATLASRECTS-3037)
oda/athena:master-ATLASRECTS-3037-v1 into master
Merged Susumu Oda requested to merge oda/athena:master-ATLASRECTS-3037-v1 into master

Define and use SiTrackMakerEventData_xk class to replace SiTrackMaker_xk::EventData struct.

https://its.cern.ch/jira/browse/ATLASRECTS-3037

  • Internal cache of SiTrackMaker_xk::EventData sometimes does not work because those are updated many methods.
  • If we add many recursive_mutex lock to many methods, we can make SiTrackMaker_xk thread-safe. However, CPU time should increase.
  • Define SiTrackMakerEventData_xk class to replace SiTrackMaker_xk::EventData.
  • Algorithms own SiTrackMakerEventData_xk and pass it to SiTrackMaker_xk.
  • mutex in SiTrackMaker_xk was removed.

Similar changes were also made for

  • SiCombinatorialTrackFinder_xk::EventData
  • SeedToTrackConversionTool::EventData

RunTier0Tests.py was fine. RunTier0Tests.log

Similar changes will be made for SiSpacePointsSeedMaker_xyz::EventData in other MRs including MR !23837 (merged).

Edited by Susumu Oda

Merge request reports

Pipeline #889738 passed

Stage: external

Pipeline passed for 8dd39dd6 on oda:master-ATLASRECTS-3037-v1

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 5 years ago (May 31, 2019 8:20pm UTC)

Merge details

  • Changes merged into master with 509ec367 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply