Make SiSpacePointsSeedTool_xk thread-safe (ATLASRECTS-3037)
Unification of EventData of SiSpacePointsSeedTool_xk
https://its.cern.ch/jira/browse/ATLASRECTS-3037
- Use std::vector instead of C array
- Change l_vertex from std::list to std::set
- The variable names were changed to avoid overlaps.
* mapOneSeeds
mapOneSeeds ['std::multimap<float,InDet::SiSpacePointsSeed*>', 4]
mapOneSeeds_Pro ['std::multimap<float,InDet::SiSpacePointsProSeed*>', 1]
mapOneSeeds_ITK ['std::multimap<float,InDet::SiSpacePointsProSeedITK*>', 1]
* OneSeeds
OneSeeds ['std::vector<InDet::SiSpacePointsSeed>', 4]
OneSeeds_Pro ['std::vector<InDet::SiSpacePointsProSeed>', 1]
OneSeeds_ITK ['std::vector<InDet::SiSpacePointsProSeedITK>', 1]
* l_seeds
l_seeds ['std::list<InDet::SiSpacePointsSeed>', 4]
l_seeds_Pro ['std::list<InDet::SiSpacePointsProSeed>', 1]
l_seeds_ITK ['std::list<InDet::SiSpacePointsProSeedITK>', 1]
l_seeds_map ['std::multimap<float,InDet::SiSpacePointsSeed*>', 1]
* i_seed
i_seed ['std::list<InDet::SiSpacePointsSeed>::iterator', 4]
i_seed_Pro ['std::list<InDet::SiSpacePointsProSeed>::iterator', 1]
i_seed_ITK ['std::list<InDet::SiSpacePointsProSeedITK>::iterator', 1]
i_seed_map ['std::multimap<float,InDet::SiSpacePointsSeed*>::iterator', 1]
* i_seede
i_seede ['std::list<InDet::SiSpacePointsSeed>::iterator', 4]
i_seede_Pro ['std::list<InDet::SiSpacePointsProSeed>::iterator', 1]
i_seede_ITK ['std::list<InDet::SiSpacePointsProSeedITK>::iterator', 1]
i_seede_map ['std::multimap<float,InDet::SiSpacePointsSeed*>::iterator', 1]
* seeds
seeds ['std::vector<InDet::SiSpacePointsSeed>', 1]
seeds_Pro ['std::multimap<float,InDet::SiSpacePointsProSeed*>', 1]
seeds_ITK ['std::multimap<float,InDet::SiSpacePointsProSeedITK*>', 1]
* seed
seed ['std::multimap<float,InDet::SiSpacePointsSeed*>::iterator', 1]
seed_Pro ['std::multimap<float,InDet::SiSpacePointsProSeed*>::iterator', 1]
seed_ITK ['std::multimap<float,InDet::SiSpacePointsProSeedITK*>::iterator', 1]
- Define a common EventData struct and use it.
- Move EventData to SiSPSeededTrackFinderData package and rename it to SiSpacePointsSeedMakerEventData.
- Algorithms or tools own SiSpacePointsSeedMakerEventData and pass it by reference to SiSpacePointsSeedTool_xk and SiZVertexTool.
RunTier0Tests.py was fine. RunTier0Tests.log
Merge request reports
Activity
added InnerDetector master review-pending-level-1 labels
removed review-pending-level-1 label
added 1 commit
- 19bab88e - Add suffix _Pro to non-ITK SiSpacePointsProSeed objects and suffix _map to multimap in Cosmic
added review-pending-level-1 label
CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-23837-2019-05-30-14-49
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39214]changed title from Modification of EventData of SiSpacePointsSeedTool_xk (ATLASRECTS-3037) to Unification of EventData of SiSpacePointsSeedTool_xk (ATLASRECTS-3037)
mentioned in merge request !23759 (merged)
CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-23837-2019-05-30-18-14
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39221] CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-23837-2019-05-30-20-24
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39228]added review-pending-level-2 label and removed review-pending-level-1 label
added 142 commits
-
bc5fd591...04e545d5 - 141 commits from branch
atlas:master
- c32f80b7 - Merge remote-tracking branch 'upstream/master' into master-SiSpacePointsSeedTool
-
bc5fd591...04e545d5 - 141 commits from branch
added review-pending-level-1 label and removed review-pending-level-2 label
added 7 commits
- 87b07e53 - Move some data classes to SiSPSeededTrackFinderData.
- 3fb6fc92 - Rename SiSpacePointsSeedTool_xk/EventData to...
- 48193143 - Use EventData
- 8ee70230 - Remove mutable data members
- 29168550 - Use SiSpacePointsSeedMakerEventData
- 9c1e79cf - Use SiSpacePointsSeedMakerEventData
- 427be677 - Add override keyword
Toggle commit listchanged title from WIP: Unification of EventData of SiSpacePointsSeedTool_xk (ATLASRECTS-3037) to Make SiSpacePointsSeedTool_xk thread-safe (ATLASRECTS-3037)
This merge request affects 7 packages:
- InnerDetector/InDetRecAlgs/SiSPSeededTrackFinder
- InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
- InnerDetector/InDetRecTools/InDetRecToolInterfaces
- InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk
- InnerDetector/InDetRecTools/SiZvertexTool_xk
- InnerDetector/InDetTrigRecAlgs/SiTrigSPSeededTrackFinder
- Trigger/TrigTools/TrigInDetRecoTools
added Trigger label
CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-23837-2019-06-01-05-06
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39302] CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-23837-2019-06-01-06-43
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39303]mentioned in merge request !23876 (closed)
This merge request affects 7 packages:
- InnerDetector/InDetRecAlgs/SiSPSeededTrackFinder
- InnerDetector/InDetRecEvent/SiSPSeededTrackFinderData
- InnerDetector/InDetRecTools/InDetRecToolInterfaces
- InnerDetector/InDetRecTools/SiSpacePointsSeedTool_xk
- InnerDetector/InDetRecTools/SiZvertexTool_xk
- InnerDetector/InDetTrigRecAlgs/SiTrigSPSeededTrackFinder
- Trigger/TrigTools/TrigInDetRecoTools
CI Result SUCCESSAthena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-23837-2019-06-02-05-29
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39319]