Manual sweep of !20214, !22860 and !23302 from 21.0 to master: PixelRadDamDigitization: Algorithm for interpolation of irraditaed E fields

This merge request sweeps three sets of changes from 21.0 to master:

• PixelRadDamDigitization: Algorithm for interpolation of irraditaed E fields See merge request !20214 (merged)

• fixed some warnings in PixelRadDamDigitization See merge request !22860 (merged)

• Fix build warnings in PixelRadDamDigitization/RadDamageUtil. See merge request !23302 (merged)

added sweep:from 21.0 label

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelRadDamDigitization

Adding @jchapman as watcher

added Digitization InnerDetector master review-pending-level-1 labels

FYI @ladam and @bnachman. I checked the conflict for !20214 (merged) and it was minor, so I decided just to do the sweep myself.

mentioned in merge request !20214 (merged)

mentioned in merge request !22860 (merged)

mentioned in merge request !23302 (merged)

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelRadDamDigitization

Adding @jchapman as watcher

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23904-2019-06-04-00-19
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39378]

Changes are substantial and require a deeper understanding of the Athena code structure/workflows, I would like to escalate this MR to the level-2 shifter for review: InnerDetector/InDetDigitization/PixelRadDamDigitization/src/EfieldInterpolator.cxx has been completely re-written. Sorry I am not expert enough: Baida L1

added review-pending-level-2 label and removed review-pending-level-1 label

Hi, I realise that this is a sweep, but there are some pretty trivial changes I think could be done here to make it a bit better.

They're not blockers, so this could be approved as long as they are followed up on later.

@ladam

Yes, I'll follow up on this issue asap.

added review-user-action-required label and removed review-pending-level-2 label

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelRadDamDigitization

Adding @jchapman as watcher

added review-pending-level-1 label and removed review-user-action-required label

resolved all discussions

added review-approved label and removed review-pending-level-1 label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-23904-2019-06-05-14-21
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 41]