Skip to content
Snippets Groups Projects

Softb multiple ops

Merged Samuel David Jones requested to merge sdjones/athena:softb_multiple_ops into 21.2
All threads resolved!

Changes to SoftBVrtCluster soft tagging tool, and to the derivations that include it. These changes are to allow multiple OPs, with track jet vetoing, in the same derivation.

Merge request reports

Pipeline #900525 passed

Pipeline passed for e5f0ebce on sdjones:softb_multiple_ops

Merged by Oana Vickey BoeriuOana Vickey Boeriu 5 years ago (Jun 11, 2019 7:38pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes look ok, just a minor comment on the OutputLevel in the files. Please comment and then resolve the discussion @sdjones. Approving in any case. Cheers, Catrin (L1 shifter)

    Edited by Catrin Bernius
  • added review-approved label and removed review-pending-level-1 label

  • Hi Catrin,

    The INFO gives details of the configuration for x3 instances of the tool and the track selection tool owned by each instance. Admittedly there is some repetition since each of the track selection tools are configured the same, but the total INFO output when I run locally comes to 130/12000 lines.

    Cheers,

    Sam

  • Samuel David Jones resolved all discussions

    resolved all discussions

  • Hi @bdong, @sanmay, @cschiavi, @lidiaz,

    Since there are changes to FTAG could I ask you please to have a look if all is OK, then I can accept it.

    Thanks, Oana

  • Hi, is it possible to run an ART test for FTAG1, FTAG2, FTAG4 before merging ? Best, Sanmay

  • Hi @sanmay,

    The ART tests themselves not sure, I think they run using the nightly itself, but you can probably see what file a particular test uses and then run locally over that with these changes.

    Best, Oana

  • Hi @sanmay,

    I ran the ART tests locally by using the commands from eg. here:

    https://gitlab.cern.ch/atlas/athena/blob/21.2/PhysicsAnalysis/DerivationFramework/DerivationFrameworkART/test/test_data18FTAG1.sh

    I have attached a tar file with all of the results for all of the modified derivations, data and MC. This included the log file, checkxAOD and checkFile results. Is this sufficient? If you would like to see anything else please let me know.

    Thanks,

    Sam

  • Hi,

    the changes are fine with me.

    Best, Sanmay

  • mentioned in commit 952a1830

  • Please register or sign in to reply
    Loading