MT implementation of Spacepoint Counting in pixel and SCT detectors

Related to ATR-19863.

This merge request is for min-bias MT implementation of Spacepoints counting in different regions of SCT and pixel detectors. This has no effect elsewhere in the trigger.

changed the description

added 147 commits

• 265d641a...8bdf2d80 - 145 commits from branch atlas:master
• bda14f29 - Merge remote-tracking branch 'remotes/t/add-min-bias-test' into MbSpCountForAthenaMT
• d64c9fcb - MT implementation of Spacepoint counting in Pixel and SCT detectors

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: 0th Version of upgrade to MT implementation of Spacepoint Counting in pixel and SCT detectors

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2MinBias
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@rbielski as watchers

added Trigger master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24079-2019-06-21-20-31
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 560]

Hi @somadutt, there are merge conflicts. Please can you resolve these? Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 557 commits

• d64c9fcb...ace37bc4 - 556 commits from branch atlas:master
• 26599dfd - Merge remote-tracking branch 'upstream/master' into MbSpCountForAthenaMT

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2MinBias
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@rbielski as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24079-2019-06-24-17-26
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 616]

Passing this to the L2 shifter Tim. @somadutt could you please expand the description of the MR with the following:

• a concise justification why the changes are necessary
• possible implications/side effects for other parts of the code
• link(s) to related JIRA tickets if applicable (see https://atlassoftwaredocs.web.cern.ch/gittutorial/merge-request/ for reference)

Thanks, Catrin (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added review-user-action-required label

Also adding the review-user-action-required for the update of the description. Please remove once this is done.

changed the description

removed review-user-action-required label

mentioned in merge request !24430 (merged)

resolved all discussions

Thanks @somadutt for moving this forward.

I left some comments, but all pretty minor.

Tim (L2)

added review-user-action-required label and removed review-pending-level-2 label

Thanks @tamartin for the helpful suggestions. We will be updating these very soon. And regarding some suggestions like adding "doOnlyBlayer" we will be taking additional suggestions and inputs from minibias before removing/adding it completely. tagging: @tbold

Hi @somadutt,

Sure - for reference that option was used by HLT_mb_sp_blayer_L1RD0_UNPAIRED_ISO (ATR-14301) for non-collision backgrounds.

Tim

added 1 commit

• cf385511 - Fixes for suggestions from @tamartin in SPCount algorithm for SCT and pixel

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2MinBias
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@rbielski as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all discussions

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24079-2019-06-25-20-59
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 639]

Thanks Tim for this review. We have seen many options in the hypo but were not sure if all are realy used by the existing chains. My preference would be to add the code as is and then extend/rework parts of it when we we have the usecase.

added 1 commit

• e32fc111 - Fixes for compilation error

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigAlgorithms/TrigT2MinBias
• Trigger/TrigValidation/TrigUpgradeTest

Adding @hartj ,@rbielski as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24079-2019-06-26-01-49
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 655]

There is still an open discussion, could you please reply to it?

added review-user-action-required label and removed review-pending-level-1 label

resolved all discussions

added review-pending-level-1 label and removed review-user-action-required label

Tim has reviewed this already as L2, so I'm approving it now. Catrin (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 367c791f