ATR-19820: adding 'athenaHLT.py: error' to error patterns.

Following the discussion in ATR-19820:

adding "athenaHLT.py: error" as error pattern for CheckLog, catching failures as in https://atlas-art-data.web.cern.ch/atlas-art-data/build-output/master/Athena/x86_64-centos7-gcc8-opt/2019-06-03T2126/TrigP1Test/test_HelloWorldHLT_run_stop_run_build/

The change was tested with test_HelloWorldHLT_run_stop_run_build.sh for the 2019-06-03T2126 nightly, catching the error as expected.
checklog.log:

Willing to acquire file checklogTrigP1Test.conf from
/cvmfs/atlas-nightlies.cern.ch/repo/sw/master/2019-06-03T2126/Athena/22.0.2/InstallArea/x86_64-centos7-gcc8-opt/share/checklogTrigP1Test.conf
symlink checklogTrigP1Test.conf
check_log.pl: checking for <<^ERROR | ERROR | FATAL |CRITICAL |ABORT_CHAIN |^Exception:|^Caught signal|^Core dump|Traceback|Shortened traceback|stack trace|^Algorithm stack:|IncludeError|inconsistent use of tabs and spaces in indentation|glibc detected|tcmalloc: allocation failed|athenaHLT.py: error>> in log.
Found messages in atn_test_athenaHLT.log (1):
athenaHLT.py: error: unrecognized arguments: --rewind
The following messages were ignored: none
FAILURE : error/fatal found in log file - see /afs/cern.ch/work/s/salderwe/private/HLTINT/20190611_ATR-19820_nightly20190603T2126/test_v1/atn_test_athenaHLT.log
NB replace rel_0 with actual nightly in this URL.

This merge request affects 1 package:

• Trigger/TrigValidation/TrigValTools

Adding @hartj ,@rbielski as watchers

added Trigger master review-pending-level-1 labels

added alsoTargeting:21.0 alsoTargeting:21.1 alsoTargeting:21.3 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24115-2019-06-12-00-50
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 272]

Dear @salderwe , please add the ATLAS robot to your fork of athena repository, as described in:

https://atlassoftwaredocs.web.cern.ch/gittutorial/gitlab-fork/#add-your-friendly-build-bot

Thanks, Pavol [as L2 MR shifter]

Thanks @pavol, I forgot after moving from private1, should be fixed now.

Otherwise seems fine from MR shifter point of view, so approving.

 Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c89b3cd8

added sweep:done label

added sweep:failed label

Sweep summary
successful:

• 21.1
• 21.3

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/812/console for details)failed:

• 21.0

mentioned in commit 2b92b7ae

mentioned in merge request !24159 (merged)

mentioned in commit 41b142a9

mentioned in merge request !24160 (merged)

Sweep to 21.0 failed because the previous sweep changing this line hasn't been merged yet - !24120 (merged). @salderwe, would you be able to cherry-pick this to 21.0 manually after !24120 (merged) is merged?

Cheers,
Rafal

mentioned in commit 6fb94141

mentioned in commit f95173d7

mentioned in merge request !24120 (merged)

mentioned in commit 55dffac1

mentioned in merge request !24514 (merged)

Manual sweep to 21.0 in !24514 (merged) was just merged, so removing the sweep:failed label.

removed sweep:failed label

mentioned in merge request !26017 (merged)

mentioned in commit e5917b77