Added an option to enable TRT HT and ToT correction also for Ar straws.

Added a new option to the TRT drift circle calculation. Allows to enable HT and ToT corrections to be applied also for Ar straws. Disabled by default to not violate frozen tier 0.

added 21.0 InnerDetector labels

Hi @cgrefe, should we start the CI for this one?

added review-user-action-required label

Ah it just started running!

This merge request affects 2 packages:

• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetRecTools/TRT_DriftCircleTool

added review-pending-level-1 label and removed review-user-action-required label

Hi @bernius, not sure why the robot did not launch the CI earlier, this should be ready to be merged.

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24168-2019-06-21-13-02
Athena: number of compilation errors 0, warnings 3
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 39634]

added review-approved label and removed review-pending-level-1 label

Everyting looks fine, approving...

Lino (L1)

merged

mentioned in commit f437d581

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• master

added sweep:ignore label and removed sweep:failed label

Hi @cgrefe ,

This MR seems to have broken the q220, q220_mp and CosmicCalo_toriod_off TCTs. Please see here (for logs, etc for q220, but the error is the same in all tests): https://bigpanda.cern.ch/job?pandaid=4393372238

The error message is: exe, 65: Non-zero return code from RAWtoESD (8); Logfile error in log.RAWtoESD: "AttributeError: 'InDet__TRT_DriftCircleToolCosmics' object has no attribute 'applyDriftTimeArCorrection'" which I can see from the changes made by this MR, is one of the variables that has been introduced. Can you have a look at your changes and run q220 (you should be able to do so with simply: Reco_tf.py --AMI q220? In the meantime I will revert this MR to allow the tests to run.

Thanks

John

mentioned in commit 5b2c441e

mentioned in merge request !24410 (merged)

mentioned in merge request !24614 (merged)

mentioned in commit d9dd5a6d