Skip to content
Snippets Groups Projects

1rdo/1execute + disable the ntups properly

Merged 1rdo/1execute + disable the ntups properly
istin/athena:nswl1_fix19_4 into 21.3
All threads resolved!
Merged Serhat Istin requested to merge istin/athena:nswl1_fix19_4 into 21.3
All threads resolved!

follow up of the ticket ATR-19347

  • guarantee 1 trg rdo container / execute
  • disable / fix ntuples properly

Merge request reports

Pipeline #935475 passed

Stage: external

    Pipeline passed for e50ffaef on istin:nswl1_fix19_4

    Approval is optional

    Merged by John Derek ChapmanJohn Derek Chapman 5 years ago (Jun 24, 2019 9:59am UTC)

    Merge details

    • Changes merged into 21.3 with 4df3eb6a.
    • Did not delete the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Pavol Strizenec added review-user-action-required label

    added review-user-action-required label

  • Serhat Istin added 1 commit

    added 1 commit

    Compare with previous version

  • Serhat Istin resolved all discussions

    resolved all discussions

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Trigger/TrigT1/TrigT1NSW
    • Trigger/TrigT1/TrigT1NSWSimTools
  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

    added review-pending-level-1 label and removed review-pending-level-2 review-user-action-required labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :white_check_mark:

    Full details available at NICOS MR-24301-2019-06-23-18-31
    :warning: Athena: number of compilation errors 0, warnings 163
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 39647]

  • Clara Nellist
    Clara Nellist @cnellist ·
    Developer

    Since the request by L2 has been implemented, I'm happy to approve now. Clara (L1)

  • Clara Nellist added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • John Derek Chapman mentioned in commit 4df3eb6a

    mentioned in commit 4df3eb6a

  • John Derek Chapman merged

    merged

  • Atlas Nightlybuild added sweep:done label

    added sweep:done label

  • Atlas Nightlybuild added sweep:failed label

    added sweep:failed label

  • A
    Atlas Nightlybuild @atnight ·
    Maintainer

    Sweep summary
    failed:

    • master
  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Owner

    Hi @istin,

    Could you cherry-pick these changes to master manually please?

    Cheers,

    John

  • I
    Serhat Istin @istin ·
    Author Developer

    @jchapman Hi did cherry pick to master

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Owner

    Great! - can you post a link to the new merge request here please?

  • I
    Serhat Istin @istin ·
    Author Developer

    see !24499 (merged)

  • John Derek Chapman removed sweep:failed label

    removed sweep:failed label

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Owner

    Thanks - I've dropped the sweep:failed label.

  • John Derek Chapman mentioned in merge request !24499 (merged)

    mentioned in merge request !24499 (merged)

  • John Derek Chapman mentioned in merge request !26017 (merged)

    mentioned in merge request !26017 (merged)

  • Atlas Nightlybuild mentioned in commit e5917b77

    mentioned in commit e5917b77

    • Please register or sign in to reply