fix clang compiler warnings
It's been a while since the last time I did this, so here is the last round of fixing all warnings we get compiling AnalysisBase with clang on MacOS.
I purposely only commented out code, not removed it, as I'm not the expert on this code, so please don't flag that. Also, I purposely made a separate commit for each package to simplify sweeping/cherry-picking down the road, so please don't check the squash commits button.
Edited by Nils Erik Krumnack