Skip to content
Snippets Groups Projects

Pfo electron links

Merged Jack MacDonald requested to merge jmacdona/athena:pfo-electron-links into master
All threads resolved!
  • Changed algorithm to allow possibility of linking electrons to multiple charged and neutral PFOs.
  • Added possibility to use electron ID criteria in PFLeptonSelector

As part of the QT described here: ATLJETMET-1066

Thanks, Jack

Also mentioning @christos, @mhodgkin, @koffas, @kristin, @psommer, @lmiller, @dgillber

Merge request reports

Pipeline #941680 passed

Pipeline passed for c6b2820d on jmacdona:pfo-electron-links

Merged by Stewart Martin-HaughStewart Martin-Haugh 5 years ago (Jun 26, 2019 5:08pm UTC)

Merge details

  • Changes merged into with 5a380ea1.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-24444-2019-06-26-01-34
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :warning: AthSimulation: number of compilation errors 0, warnings 1
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 648]

  • There is one comment to be resolved that sounds like it needs a new commit. Changing labels appropriately. Catrin (L1)

  • Jack MacDonald added 1 commit

    added 1 commit

    • c6b2820d - Update PFlowMTConfig.py to include latest changes from master

    Compare with previous version

  • This merge request affects 1 package:

    • Reconstruction/eflowRec

    Adding @mhodgkin as watcher

  • Mark Hodgkinson resolved all discussions

    resolved all discussions

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-24444-2019-06-26-16-46
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 662]

  • Chaowaroj Wanotayaroj approved this merge request

    approved this merge request

  • mentioned in commit 5a380ea1

  • Please register or sign in to reply
    Loading