TrigEgammaMonitoring migration to athenaMT (step 1)

In Run2 monitoring files have the following directory structure: /run_ABCXYZ/HLT/Egamma/Expert/<TriggerStreams>/<set_of_histgroups>/<subgroups>/<histograms>,

where <TriggerStreams> are names 'HLT_e5_lhloose', 'HLT_e28_lhtight_idperf' and so on,

<set_of_histgroups> are four directories with names 'AbsResolutions', 'Distributions', 'Efficiency', 'Resolutions',

<subgroups> are 'EFCalo', 'HLT', 'L1Calo' and so on,

<histograms> are histograms itself.

In this merge request:

• Defined new python module TrigEgammaMonToolBuilderRun3 to do all configuration configuration This module creates an instance of new TrigEgammaMonitorAlgorithm for each trigger stream. The TrigEgammaMonitorAlgorithm itself is mosly placeholder now
• In TrigEgammaMonitorAlgorithm monitoring group configured for each deepest subdirectory in the hierarchy
• Histogram definitions transfered from TrigEgammaPlotTool of TrigEgammaAnalysisTools package almost line by line. each call to addDirectory() in old code translated to creation of monitoring group
• Correct variables definition for TProfile, TH2F and TProfile2D is not supported in this MR

Related ticket ATR-19968

changed the description

added 297 commits

• 1ad105d7...c93c2d6c - 294 commits from branch atlas:master
• 7868e165 - Add helper functions for TrigEgammaMonitoring histograms migration
• 2a6a3ac6 - Transfer hitograms definitions from TrigEgammaAnalysisTools/TrigEgammaPlotTool
• 0030e2c2 - Merge remote-tracking branch 'upstream/master' into master-TrigEgammaMonitoring-MTupgrade1

Compare with previous version

changed title from WIP: TrigEgammaMonitoring migration to athenaMT to WIP: TrigEgammaMonitoring migration to athenaMT (step 1)

changed the description

added 3 commits

• 7f4345e3 - Temporary stubs for multiple variables in TProfile,TH2F,TProfile2D and...
• dca2fe10 - Change default path to place histograms into group without extra subdirectories
• df6ef558 - Test histograms filling

Compare with previous version

unmarked as a Work In Progress

This merge request affects 2 packages:

• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigMonitoring/TrigHLTMonitoring

added Egamma Trigger master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24574-2019-07-09-23-24
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1019]

All looks ok. Warning is not related to the changes. Passing on to L2 for one more check. Ruchi (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Hi @maximov,

Thank you for the MR. Thank you for nicely documenting the code, this is really appreciated! As this is still work in progress I will not delay this any further. Just a comment for the future, that you could actually convert some comments to the actual python doc strings e.g. for TH* function (I'm not sure if this is used anywhere though).

Tadej (L2)

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 1da7e3d1

added sweep:ignore label