Skip to content
Snippets Groups Projects

Update error messages to be more descriptive.

Merged Charles Burton requested to merge cburton/athena:master-error-messages into master
All threads resolved!

@pisarna @tbold @ponyisi

I've updated a few of the error messages.

  1. In AthMonitorAlgorithm, the error getGroup function told you which group name was missing, but now it also tells you from which algorithm (in case there are multiple instances of the same algorithm in a single job.)

  2. In HistogramDef, warns the user that the parsing error may have been caused by a bad use of delimiters. One user was using commas in the title, and had trouble since he presumably thought that the error was casting float to int, or something like that. If there's a better way to do this one, I can certainly try it.

Chuck

Edited by Charles Burton

Merge request reports

Pipeline #975070 passed

Pipeline passed for 61447858 on cburton:master-error-messages

Approval is optional

Merged by Edward MoyseEdward Moyse 5 years ago (Jul 15, 2019 1:58pm UTC)

Merge details

  • Changes merged into master with d3f436cd (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-24764-2019-07-10-01-38
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1028]

  • The discussions need to be resolved before it can be approved. I am changing the labels until its done. -Ruchi (L1)

  • Charles Burton added 1 commit

    added 1 commit

    • 61447858 - Add list of available groups in FATAL message

    Compare with previous version

  • Charles Burton resolved all discussions

    resolved all discussions

  • This merge request affects 1 package:

    • Control/AthenaMonitoring

    Adding @ssnyder ,@rbianchi as watchers

  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-24764-2019-07-12-23-55
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1120]

  • added review-approved label and removed review-pending-level-1 label

  • merged

  • Edward Moyse mentioned in commit d3f436cd

    mentioned in commit d3f436cd

  • Please register or sign in to reply
    Loading