Skip to content

createTrackParameters is a factory method/has ctor semantics

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:Surface_createTrackParameters_is_a_ctor into master

createTrackParameters is a factory method returning newly constructed TrackParameters.

Ideally it should return std::unique_ptr<TrackParameters>. Advertising that the caller assumes ownership in both lifetime and "properties" sense.

Step 1 is to remove the uneeded const . Given the clients changing to unique_ptr might be a much bigger undertaking but might worth it in another MR.

Mentioning @ssnyder and @amorley

Edited by Christos Anastopoulos

Merge request reports