TrigHLTJetHypo: Fix clang warnings.

clang warnings:

• Don't use std::move on rvalues.
• Classes with virtual methods should usually have a virtual dtor.
• Unused private data members.
• • used instead of << in output streaming.

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigHLTJetHypo

added JetEtmiss Trigger master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24858-2019-07-13-02-35
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1126]

ok, Athena compilation warning not related to this MR, L1 approving

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 2bd7180d

Hmm. @ssnyder I have to say I'm a bit confused by your change here.

m_config returns a unique_ptr->getJetGrouper() and so isn't std::move correct?

hi -

No. Rule of thumb is that you should only use std::move on an lvalue (i.e., something with a name), and not in a return statement. Don't use it on a temporary value as you have here.

One way to think of std::move is as a lvalue->rvalue conversion, so it doesn't make sense to apply it to something that's already an rvalue, and doing so will inhibit optimizations in some contexts. clang gives warnings about such uses.

added sweep:ignore label