Skip to content
Snippets Groups Projects

Explicitly check the validity of the objects before asking for their elements in diff_root_files.py

Merged Alaettin Serhan Mete requested to merge amete/athena:master-diff-root-safety-check into master

This MR fixes a possible run-time error by explicitly checking neither d_old nor d_new is none before trying to access their elements. In principle this shouldn't really happen as it means there is an error when dumping the contents of the trees but in practice it's not guaranteed (and sometimes happens).

-s

cc: @tcuhadar @jchapman

Merge request reports

Pipeline #975246 passed

Pipeline passed for f6e28539 on amete:master-diff-root-safety-check

Approval is optional

Merged by Edward MoyseEdward Moyse 5 years ago (Jul 16, 2019 9:39am UTC)

Merge details

  • Changes merged into master with dfc75f37.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading