MuonMDT_CnvTools: Speed up handling of dead tubes.

The search for dead tubes was like this:

for(int layer = 1; layer <= mydetEl->getNLayers(); layer++){ for(int tube = 1; tube <= mydetEl->getNtubesperlayer(); tube++){ bool tubefound = false; for(unsigned int kk=0; kk < cv->getNChildVols(); kk++) { int tubegeo = cv->getIdOfChildVol(kk) % 100; int layergeo = ( cv->getIdOfChildVol(kk) - tubegeo ) / 100; if( tubegeo == tube && layergeo == layer ) { tubefound=true; break; }

However, getNChildVols() and getIdOfChildVol() are both O(N) operations, requiring a walk of the geo graph. Further, geomodel will maintain the transform while it does so, resulting in many calls to Eigen. And Eigen is much, much, much slower in debug builds than in optimized builds. The upshot is that in debug builds, this code was taking several minutes.

Rewrite using geoGetIds so that we only need to traverse the geo graph once (well, twice actually, since i left in the initial check on getNChildVols) and so we don't need to do matrix arithmetic during this traversal.

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonMDT_CnvTools

Adding @rosati ,@wleight as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-24875-2019-07-14-10-08
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1151]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 3d8cc7d6

added sweep:ignore label