Skip to content
Snippets Groups Projects

[ATR-20039] Remove un-used parameter ViewPerRoI

Merged [ATR-20039] Remove un-used parameter ViewPerRoI
All threads resolved!
Merged Tim Martin requested to merge tamartin/athena:removeViewPerROI into master
All threads resolved!

The m_viewPerRoI property is never used. Removing it to avoid it causing confusion.

Think this logic is handled instead by the EventViewCreatorAlgorithmWithJets.cxx or EventViewCreatorAlgorithmWithMuons.cxx variants.

Ping @bwynne @fpastore @tbold

Ping @cvarni due to minor change to bjet

Edited by Tadej Novak

Merge request reports

Pipeline #991543 running

Pipeline running for cd327689 on tamartin:removeViewPerROI

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 5 years ago (Jul 24, 2019 12:09pm UTC)

Merge details

  • Changes merged into master with ffd5c45c (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tim Martin added 1 commit
  • Tim Martin resolved all discussions

    resolved all discussions

  • This merge request affects 2 packages:

    • Trigger/TrigSteer/ViewAlgs
    • Trigger/TriggerCommon/TriggerMenuMT
  • :white_check_mark: CI Result SUCCESS

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available at NICOS MR-25023-2019-07-22-16-43
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1348]

  • Tadej Novak changed the description

    changed the description

  • I guess you want to keep the comment so approving. The second pipeline got confused due to reboot campaign but only the comment was changed.

    Tadej (L2)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit ffd5c45c

  • Please register or sign in to reply
    Loading