Revert changes of SCT_FrontEnd.cxx of MR !20456 to fix ATLASSIM-4227

Revert changes of SCT_FrontEnd.cxx of MR !20456 (merged) to fix https://its.cern.ch/jira/browse/ATLASSIM-4227

added bugfix changes-digitization-output labels

This merge request affects 1 package:

• InnerDetector/InDetDigitization/SCT_Digitization

Adding @jchapman ,@oda as watchers

added 21.0 Digitization InnerDetector review-pending-level-1 labels

Hi @janders,
This one would ideally go in before 21.0.100 is built.
Cheers,
John

CI Result SUCCESS

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25026-2019-07-22-19-09
Athena: number of compilation errors 0, warnings 160
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 5
For experts only: Jenkins output [CI-MERGE-REQUEST 40018]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 2c0d94db

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• master

added sweep:ignore label and removed sweep:done sweep:failed labels

Hi @oda

This MR showed up some FT0V changes in q221 (I am not sure how this didn't show up in the CI to be honest so I'm running the test locally also to see if anything weird is going on).

The changes are in

Py:diff-root INFO Found [11313490] identical leaves Py:diff-root INFO Found [250282] different leaves Py:diff-root INFO [InDetSimDataCollection_p2_SCT_SDO_Map.m_simdata.second.m_word]: 9751 leaves differ Py:diff-root INFO [SCT_RawDataContainer_p3_SCT_RDOs]: 108457 leaves differ Py:diff-root INFO [SCT_RawDataContainer_p3_SCT_RDOs.m_collections.m_begin]: 24123 leaves differ Py:diff-root INFO [SCT_RawDataContainer_p3_SCT_RDOs.m_collections.m_end]: 24133 leaves differ Py:diff-root INFO [SCT_RawDataContainer_p3_SCT_RDOs.m_sct3data.m_rdoId]: 41913 leaves differ Py:diff-root INFO [SCT_RawDataContainer_p3_SCT_RDOs.m_sct3data.m_word]: 41905 leaves differ Py:diff-root INFO NOTE: there were errors during the dump Py:diff-root INFO fold.allgood: False Py:diff-root INFO fnew.allgood: False Py:diff-root INFO files differ!

As this is a revert of a previous MR (and that MR wasn't marked as FT0V) I'm a bit confused as to how this can be FT0V (I have seen that the previous MR was marked as FT0V but this was then removed).

If these changes are expected then that's ok, but I'm not entirely sure that they are?

Cheers

John

(the logfile is available here a warning, it is very large)

Yes, it was reverting the FT0V changes in !20456 (merged).

Hi @janders,

Sorry, I forgot the frozen Tier0 policy. Yes, this MR violates the frozen Tier0 policy. This is because the the previous MR !20456 (merged). This was an unitentional violation. The reversion of this MR to fix the unintentional violation of MR !20456 (merged).

I compared RDO files by q221 with r03 and r08 and saw differences. I also compared RDO files by q221 with r03 and r08 + this MR and saw no differences.

Cheers, Susumu

Thanks @oda, that was a much better answer than mine. :-)

Maybe we add the frozen-tier0-violating label to both MRs?

added frozen-tier0-violating label

Hi @oda and @jchapman,

No problem, I was just a bit confused that reverting this was FT0V when the previous MR wasn't labelled as FT0V, so just checking everything is as expected :)

Cheers

John

mentioned in merge request !25152 (merged)

mentioned in merge request !25152 (merged)

mentioned in commit 6092b5bd