Third step with dummy btagging

Opening WIP MR for discussing this.

Description: Addition of third step in the b-jet triggers. This is a dummy sequence since it does not actually compute b-tagging and does not cut on it (the hypo tool passes all the events). The TrigBtagFexMT will be replaced with the offline algorithms.

Also, in this MR Primary Vertex and Precision tracks are attached to navigation.

Tagging @cschiavi, @tamartin, @fpastore and @tbold

changed the description

What exactly you want to be looked into?

Hi @tbold, I'm concerned about the following things:

• I'm attaching tracks to the decision in this way(https://gitlab.cern.ch/cvarni/athena/blob/ThirdStepWithBtagging/Trigger/TrigHypothesis/TrigBjetHypo/src/TrigBjetEtHypoAlgEVMT.cxx#L39). I'm using the addObjectCollectionLinks because I could not find a setObjectCollectionLinks method.I assumed that is the correct way or is there another recommended function for that?
• When printing the output decisions I see a lot of tracks__COLL attached to it. I'm assuming this is what I'm supposed to see when attaching an Element Link Vector. Or is there something not correct in this?
• Precision tracks are actually created in an event view. Yet I need to do this when creating the Element Link ElementLink< xAOD::TrackParticleContainer > trackEL( trackKey.key(),i );. If I don't the code says the link is not valid. Does it suggest it is stored in StoreGate somehow?
• Linked to the previous point, the TrigBtagFexMT retrieves precision tracks from store gate. I was not expecting this to be possible since I can't do that for GSC jets (again, created in even view context).
• I need @cschiavi to comment on the inputs to TrigBtagFexMT. That should be all we need to compute the b-tagging score.

Carlo

added 458 commits

• bfda17d4...3877d03a - 457 commits from branch atlas:master
• c349ec32 - Sycn with master

Compare with previous version

Hi @tamartin, I was trying to add the primary vertex to the EDM but I got the following error message

StreamESD                               5   0     ERROR  INCORRECT Object/count: xAOD::VertexAuxContainer_HLT_EFHistoPrmVtxAux., 1 should be: 6
StreamESD                               5   0     ERROR  INCORRECT Object/count: xAOD::VertexContainer_HLT_EFHistoPrmVtx, 1 should be: 6
StreamESD                               5   0     FATAL Check number of writes failed. See messages above to identify which container is not always written
StreamESD                               5   0     ERROR Maximum number of errors ( 'ErrorMax':1) reached.
AlgoExecutionTask                       5   0   WARNING Execution of algorithm StreamESD failed
AvalancheSchedulerSvc                   5   0     ERROR *** Stall detected in slot 0! ***
AvalancheSchedulerSvc                   5   0     ERROR Event 5 on slot 0 failed
AvalancheSchedulerSvc                   5   0      INFO Dumping scheduler state

Do you know what this means?

Cheers, Carlo

Hi @cvarni

Mmm, I came across a similar one not too long back. What this means is that no xAOD::VertexContainer_HLT_EFHistoPrmVtx collection is created in events #0-#5 (as your chain didn't run), but then it did run in #6.

This breaks the rule that the exact same set of collections should be produced in every event.

Thankfully the fix is relatively easy. See here https://atlassoftwaredocs.web.cern.ch/guides/trigger/algos/#saving-edm-objects - you need to add your collection to TriggerEDMRun3.py and (because you're the first to try and save a Vertex container) add VertexContainer to HLTEDMCreator.h in a few places, following the instructions in that class' header.

With that done, the EDM creator will produce a dummy output collection in events in which your chain was not active up to this point.

added 1 commit

• 40d4377b - Adding Vertex Container to EDM

Compare with previous version

unmarked as a Work In Progress

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @hartj ,@cvarni ,@sekula ,@rbielski ,@bernius as watchers

added JetEtmiss Trigger TriggerEDM TriggerMenu master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests		N/A

Full details available at NICOS MR-25043-2019-08-01-03-48
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1678]

Jenkins please retry a build

Restarted as tests were interrupted for CI system maintenance (disk cleanup to mitigate incremental build problems)

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @hartj ,@cvarni ,@sekula ,@rbielski ,@bernius as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25043-2019-08-01-11-36
Athena: number of compilation errors 0, warnings 3
AthSimulation: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1680]

added 1 commit

• ce9e2bb5 - Update of reference file

Compare with previous version

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius ,@hartj ,@cvarni ,@sekula ,@rbielski ,@jpanduro as watchers

Hi @cvarni,

You also have some linting errors

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py:87:5: ATL900: Do not assign an explicit OutputLevel
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py:218:5: ATL900: Do not assign an explicit OutputLevel
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py:280:5: ATL900: Do not assign an explicit OutputLevel
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py:292:5: ATL900: Do not assign an explicit OutputLevel
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py:303:62: E703 statement ends with a semicolon
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Bjet/BjetSequenceSetup.py:304:5: ATL900: Do not assign an explicit OutputLevel

added 1 commit

• b373ee13 - Minor chagens

Compare with previous version

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius ,@hartj ,@cvarni ,@sekula ,@rbielski ,@jpanduro as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25043-2019-08-01-21-14
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1692]

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25043-2019-08-01-21-38
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1695]

added 175 commits

• b373ee13...56f86515 - 174 commits from branch atlas:master
• 692c9e13 - Sync with master

Compare with previous version

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius ,@hartj ,@cvarni ,@sekula ,@okuprash ,@rbielski ,@jpanduro as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25043-2019-08-03-08-14
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1766]

added 1 commit

• a94a955e - Update of reference files

Compare with previous version

added Squash commits label

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius ,@hartj ,@cvarni ,@sekula ,@okuprash ,@rbielski ,@jpanduro as watchers

CI Result FAILURE

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25043-2019-08-03-23-08
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1770]

added 1 commit

• 1e3d148c - Update of full_menu_build.ref file

Compare with previous version

This merge request affects 7 packages:

• Trigger/TrigHypothesis/TrigBjetHypo
• Trigger/TrigSteer/TrigOutputHandling
• Trigger/TrigSteer/ViewAlgs
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigUpgradeTest
• Trigger/TriggerCommon/TrigEDMConfig
• Trigger/TriggerCommon/TriggerMenuMT

Adding @bernius ,@hartj ,@cvarni ,@sekula ,@okuprash ,@rbielski ,@jpanduro as watchers

CI Result SUCCESS

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available at NICOS MR-25043-2019-08-04-03-56
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 1773]

added review-user-action-required label and removed review-pending-level-1 label

resolved all discussions

added review-pending-level-1 label and removed review-user-action-required label

Resolved the discussion - Tim

Thanks Tim! I've made some comments on removing commented code. I'll resolve them, please take care of this in another MR. I prefer to approve now as it's a rather extensive one before it accumulates conflicts.

resolved all discussions

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 05fcabd5

added sweep:ignore label