Add new Tile Digitization config to CI test
Add Tile Digitization to DigitizationConfigNew_test. Includes TileDigitsMaker, TileHitVecToCnt, TileHitToTTL1 and TileHitToTTL1.
Modify each to allow standalone execution.
Add optional OutputStream configuration.
Add TileDigitizationConfig.py script for combination.
Merge request reports
Activity
added NewConfig label
Hi @harkusha,
I understand from !25344 (merged) discussion that you are actively working here, so I hope this doesn't get in your way. Any comments?
Cheers, Rupert
added Digitization JetEtmiss Simulation Tile master review-pending-level-1 labels
- Resolved by Rupert Tombs
Hi @rtombs,
My idea was to combine everything needed for Tile digitization in one function like TileDigitizationCfg in one configuration file like TileDigitizationConfig.py in TileSimAlgs package, and then only this one function can be used here in this test.
But if it is ok for you and @jchapman then please go ahead. And thanks for the migration of Tile parts here.
But what about TileDigitsMaker (and probably Tile muon receiver)? I don't see them here.
Cheers, Siarhei
- Last reply by Rupert Tombs
-
Hi @harkusha,
Which of the TileRawChannelBuilder config methods should we use in the "standard" digitization configuration?
https://gitlab.cern.ch/atlas/athena/tree/master/TileCalorimeter/TileRecUtils/python
Once we have that we could include the tile muon receiver too.Cheers,
John
- Resolved by Rupert Tombs
Hi @jchapman,
My idea was to use TileRawChannelMakerCfg from TileRawChannelMakerConfig.py directly. All corresponding flags steering which Tile raw channel builder to use should be configured automatically. But at this moment I'm not sure that it works out of the box in this case. My goal was to look at this later.
So, when this merge request (without Tile raw channel builders) will be merged I can play a bit with raw channel maker and configure it correctly.
But if you would like you can try to use this function: TileRawChannelMakerCfg(flags). It's very likely that it works.
Cheers, Siarhei
- Last reply by Rupert Tombs
Athena AthSimulation externals 
cmake make required tests 
optional tests Full details available at NICOS MR-25363-2019-08-05-16-40
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-25363-2019-08-05-19-19
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-25363-2019-08-05-23-04
Resolved by Rupert TombsHi @rtombs, the flake8 tests are failing. Could you please have a look?
Tadej (L2)
- Last reply by Rupert Tombs
added review-user-action-required label and removed review-pending-level-1 label
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation externals cmake make required tests optional tests Full details available at NICOS MR-25363-2019-08-06-17-10
Changes look ok, approving. Build warning doesn't seem related as it's in DataQuality with this error:
Error in <TInterpreter::TCling::AutoLoad>: failure loading library libGoodRunsListsLib.so for pair<TString,TString> No "file" defined for LVL1_Interfaces/Calorimeter/CaloTriggerTowerEnergyDistribution/all_in_dir No "file" defined for LVL1_Interfaces/Calorimeter/CaloTriggerTowerHitMaps/all_in_diradded review-approved label and removed review-pending-level-1 label
mentioned in commit f120cff3
added sweep:ignore label